Patch "net: stmmac: Fix unbalanced IRQ wake disable warning on single irq case" has been added to the 6.11-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    net: stmmac: Fix unbalanced IRQ wake disable warning on single irq case

to the 6.11-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     net-stmmac-fix-unbalanced-irq-wake-disable-warning-o.patch
and it can be found in the queue-6.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit f14f9a3ebe01d33d25e8f773a75b7d95c9f50c85
Author: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
Date:   Fri Nov 1 17:17:29 2024 -0400

    net: stmmac: Fix unbalanced IRQ wake disable warning on single irq case
    
    [ Upstream commit 25d70702142ac2115e75e01a0a985c6ea1d78033 ]
    
    Commit a23aa0404218 ("net: stmmac: ethtool: Fixed calltrace caused by
    unbalanced disable_irq_wake calls") introduced checks to prevent
    unbalanced enable and disable IRQ wake calls. However it only
    initialized the auxiliary variable on one of the paths,
    stmmac_request_irq_multi_msi(), missing the other,
    stmmac_request_irq_single().
    
    Add the same initialization on stmmac_request_irq_single() to prevent
    "Unbalanced IRQ <x> wake disable" warnings from being printed the first
    time disable_irq_wake() is called on platforms that run on that code
    path.
    
    Fixes: a23aa0404218 ("net: stmmac: ethtool: Fixed calltrace caused by unbalanced disable_irq_wake calls")
    Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>
    Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
    Link: https://patch.msgid.link/20241101-stmmac-unbalanced-wake-single-fix-v1-1-5952524c97f0@xxxxxxxxxxxxx
    Signed-off-by: Paolo Abeni <pabeni@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 02368917efb4a..afb8a5a079fa0 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -3794,6 +3794,7 @@ static int stmmac_request_irq_single(struct net_device *dev)
 	/* Request the Wake IRQ in case of another line
 	 * is used for WoL
 	 */
+	priv->wol_irq_disabled = true;
 	if (priv->wol_irq > 0 && priv->wol_irq != dev->irq) {
 		ret = request_irq(priv->wol_irq, stmmac_interrupt,
 				  IRQF_SHARED, dev->name, dev);




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux