Patch "net: dpaa_eth: print FD status in CPU endianness in dpaa_eth_fd tracepoint" has been added to the 6.11-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    net: dpaa_eth: print FD status in CPU endianness in dpaa_eth_fd tracepoint

to the 6.11-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     net-dpaa_eth-print-fd-status-in-cpu-endianness-in-dp.patch
and it can be found in the queue-6.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 78863d1f98c5f9642ac29036d0a5afd2e7f52866
Author: Vladimir Oltean <vladimir.oltean@xxxxxxx>
Date:   Tue Oct 29 18:31:05 2024 +0200

    net: dpaa_eth: print FD status in CPU endianness in dpaa_eth_fd tracepoint
    
    [ Upstream commit 0144c06c5890d1ad0eea65df074cffaf4eea5a3c ]
    
    Sparse warns:
    
    note: in included file (through ../include/trace/trace_events.h,
    ../include/trace/define_trace.h,
    ../drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h):
    warning: incorrect type in assignment (different base types)
       expected unsigned int [usertype] fd_status
       got restricted __be32 const [usertype] status
    
    We take struct qm_fd :: status, store it and print it as an u32,
    though it is a big endian field. We should print the FD status in
    CPU endianness for ease of debug and consistency between PowerPC and
    Arm systems.
    
    Though it is a not often used debug feature, it is best to treat it as
    a bug and backport the format change to all supported stable kernels,
    for consistency.
    
    Fixes: eb11ddf36eb8 ("dpaa_eth: add trace points")
    Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
    Acked-by: Madalin Bucur <madalin.bucur@xxxxxxxxxxx>
    Link: https://patch.msgid.link/20241029163105.44135-1-vladimir.oltean@xxxxxxx
    Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h b/drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h
index 6f0e58a2a58ad..9e1d44ae92cce 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth_trace.h
@@ -56,7 +56,7 @@ DECLARE_EVENT_CLASS(dpaa_eth_fd,
 		__entry->fd_format = qm_fd_get_format(fd);
 		__entry->fd_offset = qm_fd_get_offset(fd);
 		__entry->fd_length = qm_fd_get_length(fd);
-		__entry->fd_status = fd->status;
+		__entry->fd_status = __be32_to_cpu(fd->status);
 		__assign_str(name);
 	),
 




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux