Patch "drm/xe: Take job list lock in xe_sched_add_pending_job" has been added to the 6.11-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    drm/xe: Take job list lock in xe_sched_add_pending_job

to the 6.11-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     drm-xe-take-job-list-lock-in-xe_sched_add_pending_jo.patch
and it can be found in the queue-6.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 8d30d74cd5e49d7ea556f9ea96ed56ea2356097c
Author: Matthew Brost <matthew.brost@xxxxxxxxx>
Date:   Wed Oct 2 17:16:56 2024 -0700

    drm/xe: Take job list lock in xe_sched_add_pending_job
    
    [ Upstream commit ed931fb40e353586f26c3327813d142f782f5f78 ]
    
    A fragile micro optimization in xe_sched_add_pending_job relied on both
    the GPU scheduler being stopped and fence signaling stopped to safely
    add a job to the pending list without the job list lock in
    xe_sched_add_pending_job. Remove this optimization and just take the job
    list lock.
    
    Fixes: 7ddb9403dd74 ("drm/xe: Sample ctx timestamp to determine if jobs have timed out")
    Signed-off-by: Matthew Brost <matthew.brost@xxxxxxxxx>
    Reviewed-by: Matthew Auld <matthew.auld@xxxxxxxxx>
    Link: https://patchwork.freedesktop.org/patch/msgid/20241003001657.3517883-2-matthew.brost@xxxxxxxxx
    (cherry picked from commit 90521df5fc43980e4575bd8c5b1cb62afe1a9f5f)
    Signed-off-by: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/gpu/drm/xe/xe_gpu_scheduler.h b/drivers/gpu/drm/xe/xe_gpu_scheduler.h
index 6aac7fe686735..6bdd0a5b36122 100644
--- a/drivers/gpu/drm/xe/xe_gpu_scheduler.h
+++ b/drivers/gpu/drm/xe/xe_gpu_scheduler.h
@@ -51,7 +51,9 @@ xe_sched_invalidate_job(struct xe_sched_job *job, int threshold)
 static inline void xe_sched_add_pending_job(struct xe_gpu_scheduler *sched,
 					    struct xe_sched_job *job)
 {
+	spin_lock(&sched->base.job_list_lock);
 	list_add(&job->drm.list, &sched->base.pending_list);
+	spin_unlock(&sched->base.job_list_lock);
 }
 
 static inline




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux