From: Jan Kara <jack@xxxxxxx> [ Upstream commit 00bce6f792caccefa73daeaf9bde82d24d50037f ] Convert udf_mkdir() to new directory iteration code. Signed-off-by: Jan Kara <jack@xxxxxxx> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- fs/udf/namei.c | 48 +++++++++++++++++++++--------------------------- 1 file changed, 21 insertions(+), 27 deletions(-) --- a/fs/udf/namei.c +++ b/fs/udf/namei.c @@ -928,8 +928,7 @@ static int udf_mkdir(struct user_namespa struct dentry *dentry, umode_t mode) { struct inode *inode; - struct udf_fileident_bh fibh; - struct fileIdentDesc cfi, *fi; + struct udf_fileident_iter iter; int err; struct udf_inode_info *dinfo = UDF_I(dir); struct udf_inode_info *iinfo; @@ -941,47 +940,42 @@ static int udf_mkdir(struct user_namespa iinfo = UDF_I(inode); inode->i_op = &udf_dir_inode_operations; inode->i_fop = &udf_dir_operations; - fi = udf_add_entry(inode, NULL, &fibh, &cfi, &err); - if (!fi) { - inode_dec_link_count(inode); + err = udf_fiiter_add_entry(inode, NULL, &iter); + if (err) { + clear_nlink(inode); discard_new_inode(inode); - goto out; + return err; } set_nlink(inode, 2); - cfi.icb.extLength = cpu_to_le32(inode->i_sb->s_blocksize); - cfi.icb.extLocation = cpu_to_lelb(dinfo->i_location); - *(__le32 *)((struct allocDescImpUse *)cfi.icb.impUse)->impUse = + iter.fi.icb.extLength = cpu_to_le32(inode->i_sb->s_blocksize); + iter.fi.icb.extLocation = cpu_to_lelb(dinfo->i_location); + *(__le32 *)((struct allocDescImpUse *)iter.fi.icb.impUse)->impUse = cpu_to_le32(dinfo->i_unique & 0x00000000FFFFFFFFUL); - cfi.fileCharacteristics = + iter.fi.fileCharacteristics = FID_FILE_CHAR_DIRECTORY | FID_FILE_CHAR_PARENT; - udf_write_fi(inode, &cfi, fi, &fibh, NULL, NULL); - brelse(fibh.sbh); + udf_fiiter_write_fi(&iter, NULL); + udf_fiiter_release(&iter); mark_inode_dirty(inode); - fi = udf_add_entry(dir, dentry, &fibh, &cfi, &err); - if (!fi) { + err = udf_fiiter_add_entry(dir, dentry, &iter); + if (err) { clear_nlink(inode); - mark_inode_dirty(inode); discard_new_inode(inode); - goto out; + return err; } - cfi.icb.extLength = cpu_to_le32(inode->i_sb->s_blocksize); - cfi.icb.extLocation = cpu_to_lelb(iinfo->i_location); - *(__le32 *)((struct allocDescImpUse *)cfi.icb.impUse)->impUse = + iter.fi.icb.extLength = cpu_to_le32(inode->i_sb->s_blocksize); + iter.fi.icb.extLocation = cpu_to_lelb(iinfo->i_location); + *(__le32 *)((struct allocDescImpUse *)iter.fi.icb.impUse)->impUse = cpu_to_le32(iinfo->i_unique & 0x00000000FFFFFFFFUL); - cfi.fileCharacteristics |= FID_FILE_CHAR_DIRECTORY; - udf_write_fi(dir, &cfi, fi, &fibh, NULL, NULL); + iter.fi.fileCharacteristics |= FID_FILE_CHAR_DIRECTORY; + udf_fiiter_write_fi(&iter, NULL); + udf_fiiter_release(&iter); inc_nlink(dir); dir->i_ctime = dir->i_mtime = current_time(dir); mark_inode_dirty(dir); d_instantiate_new(dentry, inode); - if (fibh.sbh != fibh.ebh) - brelse(fibh.ebh); - brelse(fibh.sbh); - err = 0; -out: - return err; + return 0; } static int empty_dir(struct inode *dir) Patches currently in stable-queue which might be from cascardo@xxxxxxxxxx are queue-5.15/udf-handle-error-when-expanding-directory.patch queue-5.15/udf-convert-empty_dir-to-new-directory-iteration-code.patch queue-5.15/udf-fix-bogus-checksum-computation-in-udf_rename.patch queue-5.15/udf-convert-udf_expand_dir_adinicb-to-new-directory-iteration.patch queue-5.15/udf-convert-udf_unlink-to-new-directory-iteration-code.patch queue-5.15/udf-convert-udf_add_nondir-to-new-directory-iteration.patch queue-5.15/udf-convert-udf_link-to-new-directory-iteration-code.patch queue-5.15/udf-remove-old-directory-iteration-code.patch queue-5.15/udf-don-t-return-bh-from-udf_expand_dir_adinicb.patch queue-5.15/udf-new-directory-iteration-code.patch queue-5.15/udf-convert-udf_rmdir-to-new-directory-iteration-code.patch queue-5.15/udf-move-udf_expand_dir_adinicb-to-its-callsite.patch queue-5.15/udf-convert-udf_readdir-to-new-directory-iteration.patch queue-5.15/udf-convert-udf_mkdir-to-new-directory-iteration-code.patch queue-5.15/udf-provide-function-to-mark-entry-as-deleted-using-new-directory-iteration-code.patch queue-5.15/udf-convert-udf_lookup-to-use-new-directory-iteration-code.patch queue-5.15/udf-implement-adding-of-dir-entries-using-new-iteration-code.patch queue-5.15/udf-convert-udf_rename-to-new-directory-iteration-code.patch queue-5.15/udf-convert-udf_get_parent-to-new-directory-iteration-code.patch queue-5.15/udf-implement-searching-for-directory-entry-using-new-iteration-code.patch