From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
commit eb8333673e1ebc2418980b664a84c91b4e98afc4 upstream.
This is an error path so set the error code. Smatch complains about the
current code:
drivers/opp/core.c:2660 dev_pm_opp_set_config()
error: uninitialized symbol 'ret'.
Fixes: e37440e7e2c2 ("OPP: Call dev_pm_opp_set_opp() for required OPPs")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
Link: https://lore.kernel.org/r/3f3660af-4ea0-4a89-b3b7-58de7b16d7a5@stanley.mountain
Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/opp/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/opp/core.c b/drivers/opp/core.c
index 494f8860220d..3aa18737470f 100644
--- a/drivers/opp/core.c
+++ b/drivers/opp/core.c
@@ -2630,8 +2630,10 @@ int dev_pm_opp_set_config(struct device *dev, struct dev_pm_opp_config *config)
/* Attach genpds */
if (config->genpd_names) {
- if (config->required_devs)
+ if (config->required_devs) {
+ ret = -EINVAL;
goto err;
+ }
ret = _opp_attach_genpd(opp_table, dev, config->genpd_names,
config->virt_devs);
--
2.47.0
Patches currently in stable-queue which might be from dan.carpenter@xxxxxxxxxx are
queue-6.11/fs-ntfs3-refactor-enum_rstbl-to-suppress-static-chec.patch
queue-6.11/opp-fix-error-code-in-dev_pm_opp_set_config.patch
queue-6.11/sunrpc-fix-integer-overflow-in-decode_rc_list.patch
queue-6.11/staging-vme_user-added-bound-check-to-geoid.patch
queue-6.11/vdpa-octeon_ep-fix-format-specifier-for-pointers-in-.patch
queue-6.11/rxrpc-fix-uninitialised-variable-in-rxrpc_send_data.patch
