Patch "lib/build_OID_registry: avoid non-destructive substitution for Perl < 5.13.2 compat" has been added to the 6.6-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    lib/build_OID_registry: avoid non-destructive substitution for Perl < 5.13.2 compat

to the 6.6-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     lib-build_oid_registry-avoid-non-destructive-substit.patch
and it can be found in the queue-6.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit ed1dae2bbde03acc8c8fb7af1daefd2c6c6f6618
Author: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
Date:   Mon Jul 1 17:58:01 2024 +0200

    lib/build_OID_registry: avoid non-destructive substitution for Perl < 5.13.2 compat
    
    [ Upstream commit 2fe29fe945637b9834c5569fbb1c9d4f881d8263 ]
    
    On a system with Perl 5.12.1, commit 5ef6dc08cfde
    ("lib/build_OID_registry: don't mention the full path of the script in
    output") causes the build to fail with the error below.
    
         Bareword found where operator expected at ./lib/build_OID_registry line 41, near "s#^\Q$abs_srctree/\E##r"
         syntax error at ./lib/build_OID_registry line 41, near "s#^\Q$abs_srctree/\E##r"
         Execution of ./lib/build_OID_registry aborted due to compilation errors.
         make[3]: *** [lib/Makefile:352: lib/oid_registry_data.c] Error 255
    
    Ahmad Fatoum analyzed that non-destructive substitution is only supported since
    Perl 5.13.2. Instead of dropping `r` and having the side effect of modifying
    `$0`, introduce a dedicated variable to support older Perl versions.
    
    Link: https://lkml.kernel.org/r/20240702223512.8329-2-pmenzel@xxxxxxxxxxxxx
    Link: https://lkml.kernel.org/r/20240701155802.75152-1-pmenzel@xxxxxxxxxxxxx
    Fixes: 5ef6dc08cfde ("lib/build_OID_registry: don't mention the full path of the script in output")
    Link: https://lore.kernel.org/all/259f7a87-2692-480e-9073-1c1c35b52f67@xxxxxxxxxxxxx/
    Signed-off-by: Paul Menzel <pmenzel@xxxxxxxxxxxxx>
    Suggested-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
    Cc: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
    Cc: Nicolas Schier <nicolas@xxxxxxxxx>
    Cc: Masahiro Yamada <masahiroy@xxxxxxxxxx>
    Cc: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
    Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/lib/build_OID_registry b/lib/build_OID_registry
index 56d8bafeb848b..8267e8d71338b 100755
--- a/lib/build_OID_registry
+++ b/lib/build_OID_registry
@@ -38,7 +38,9 @@ close IN_FILE || die;
 #
 open C_FILE, ">$ARGV[1]" or die;
 print C_FILE "/*\n";
-print C_FILE " * Automatically generated by ", $0 =~ s#^\Q$abs_srctree/\E##r, ".  Do not edit\n";
+my $scriptname = $0;
+$scriptname =~ s#^\Q$abs_srctree/\E##;
+print C_FILE " * Automatically generated by ", $scriptname, ".  Do not edit\n";
 print C_FILE " */\n";
 
 #




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux