From: Takashi Iwai <tiwai@xxxxxxx>
commit fef1ac950c600ba50ef4d65ca03c8dae9be7f9ea upstream.
One snd_power_unref() was forgotten and left at __snd_ctl_elem_info()
in the previous change for reorganizing the locking order.
Fixes: fcc62b19104a ("ALSA: control: Take power_ref lock primarily")
Link: https://github.com/thesofproject/linux/pull/5127
Link: https://patch.msgid.link/20240801064203.30284-1-tiwai@xxxxxxx
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
sound/core/control.c | 1 -
1 file changed, 1 deletion(-)
--- a/sound/core/control.c
+++ b/sound/core/control.c
@@ -1168,7 +1168,6 @@ static int __snd_ctl_elem_info(struct sn
info->access = 0;
#endif
result = kctl->info(kctl, info);
- snd_power_unref(card);
if (result >= 0) {
snd_BUG_ON(info->access);
index_offset = snd_ctl_get_ioff(kctl, &info->id);
Patches currently in stable-queue which might be from tiwai@xxxxxxx are
queue-6.11/alsa-usb-audio-replace-complex-quirk-lines-with-macr.patch
queue-6.11/alsa-control-fix-power_ref-lock-order-for-compat-cod.patch
queue-6.11/alsa-hda-realtek-add-quirk-for-huawei-matebook-13-klv-wx9.patch
queue-6.11/alsa-hda-realtek-fix-mute-micmute-led-for-hp-mt645-g8.patch
queue-6.11/alsa-usb-audio-support-multiple-control-interfaces.patch
queue-6.11/alsa-usb-audio-define-macros-for-quirk-table-entries.patch
queue-6.11/alsa-usb-audio-add-native-dsd-support-for-luxman-d-08u.patch
queue-6.11/alsa-line6-add-hw-monitor-volume-control-to-pod-hd500x.patch
queue-6.11/alsa-hda-realtek-add-a-quirk-for-hp-pavilion-15z-ec200.patch
queue-6.11/alsa-hda-generic-unconditionally-prefer-preferred_da.patch
queue-6.11/alsa-asihpi-fix-potential-oob-array-access.patch
queue-6.11/revert-alsa-hda-conditionally-use-snooping-for-amd-hdmi.patch
queue-6.11/alsa-usb-audio-add-input-value-sanity-checks-for-sta.patch
queue-6.11/alsa-hda-realtek-refactor-and-simplify-samsung-galax.patch
queue-6.11/alsa-hda-tas2781-add-new-quirk-for-lenovo-y990-laptop.patch
queue-6.11/alsa-control-take-power_ref-lock-primarily.patch
queue-6.11/alsa-usb-audio-add-delay-quirk-for-vivo-usb-c-headset.patch
queue-6.11/alsa-hda-conexant-fix-conflicting-quirk-for-system76.patch
queue-6.11/alsa-usb-audio-add-mixer-quirk-for-rme-digiface-usb.patch
queue-6.11/alsa-usb-audio-add-quirk-for-rme-digiface-usb.patch
queue-6.11/alsa-hdsp-break-infinite-midi-input-flush-loop.patch
queue-6.11/alsa-core-add-isascii-check-to-card-id-generator.patch
queue-6.11/alsa-control-fix-leftover-snd_power_unref.patch
queue-6.11/alsa-gus-fix-some-error-handling-paths-related-to-ge.patch
queue-6.11/alsa-usb-audio-add-logitech-audio-profile-quirk.patch
queue-6.11/alsa-hda-realtek-fix-the-push-button-function-for-th.patch
queue-6.11/alsa-mixer_oss-remove-some-incorrect-kfree_const-usa.patch
