From: Baokun Li <libaokun1@xxxxxxxxxx>
commit 369c944ed1d7c3fb7b35f24e4735761153afe7b3 upstream.
Even though ext4_find_extent() returns an error, ext4_insert_range() still
returns 0. This may confuse the user as to why fallocate returns success,
but the contents of the file are not as expected. So propagate the error
returned by ext4_find_extent() to avoid inconsistencies.
Fixes: 331573febb6a ("ext4: Add support FALLOC_FL_INSERT_RANGE for fallocate")
Cc: stable@xxxxxxxxxx
Signed-off-by: Baokun Li <libaokun1@xxxxxxxxxx>
Reviewed-by: Jan Kara <jack@xxxxxxx>
Reviewed-by: Ojaswin Mujoo <ojaswin@xxxxxxxxxxxxx>
Tested-by: Ojaswin Mujoo <ojaswin@xxxxxxxxxxxxx>
Link: https://patch.msgid.link/20240822023545.1994557-11-libaokun@xxxxxxxxxxxxxxx
Signed-off-by: Theodore Ts'o <tytso@xxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/ext4/extents.c | 1 +
1 file changed, 1 insertion(+)
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -5750,6 +5750,7 @@ int ext4_insert_range(struct inode *inod
path = ext4_find_extent(inode, offset_lblk, NULL, 0);
if (IS_ERR(path)) {
up_write(&EXT4_I(inode)->i_data_sem);
+ ret = PTR_ERR(path);
goto out_stop;
}
Patches currently in stable-queue which might be from libaokun1@xxxxxxxxxx are
queue-4.19/ext4-fix-double-brelse-the-buffer-of-the-extents-path.patch
queue-4.19/ext4-update-orig_path-in-ext4_find_extent.patch
queue-4.19/ext4-aovid-use-after-free-in-ext4_ext_insert_extent.patch
queue-4.19/ext4-fix-slab-use-after-free-in-ext4_split_extent_at.patch
queue-4.19/ext4-propagate-errors-from-ext4_find_extent-in-ext4_insert_range.patch
