From: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>
commit e2c85d85a05f16af2223fcc0195ff50a7938b372 upstream.
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable when request IRQ.
Fixes: 37692de5d523 ("i2c: i2c-qcom-geni: Add bus driver for the Qualcomm GENI I2C controller")
Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx> # v4.19+
Acked-by: Mukesh Kumar Savaliya <quic_msavaliy@xxxxxxxxxxx>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@xxxxxxxxxx>
Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/i2c/busses/i2c-qcom-geni.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -569,15 +569,13 @@ static int geni_i2c_probe(struct platfor
init_completion(&gi2c->done);
spin_lock_init(&gi2c->lock);
platform_set_drvdata(pdev, gi2c);
- ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, 0,
+ ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, IRQF_NO_AUTOEN,
dev_name(dev), gi2c);
if (ret) {
dev_err(dev, "Request_irq failed:%d: err:%d\n",
gi2c->irq, ret);
return ret;
}
- /* Disable the interrupt so that the system can enter low-power mode */
- disable_irq(gi2c->irq);
i2c_set_adapdata(&gi2c->adap, gi2c);
gi2c->adap.dev.parent = dev;
gi2c->adap.dev.of_node = dev->of_node;
Patches currently in stable-queue which might be from ruanjinjie@xxxxxxxxxx are
queue-5.10/bluetooth-btmrvl-use-irqf_no_autoen-flag-in-request_.patch
queue-5.10/nfp-use-irqf_no_autoen-flag-in-request_irq.patch
queue-5.10/spi-spi-imx-fix-pm_runtime_set_suspended-with-runtim.patch
queue-5.10/net-enetc-use-irqf_no_autoen-flag-in-request_irq.patch
queue-5.10/spi-bcm63xx-fix-module-autoloading.patch
queue-5.10/riscv-fix-fp-alignment-bug-in-perf_callchain_user.patch
queue-5.10/spi-spi-fsl-lpspi-undo-runtime-pm-changes-at-driver-.patch
queue-5.10/net-ieee802154-mcr20a-use-irqf_no_autoen-flag-in-req.patch
queue-5.10/i2c-qcom-geni-use-irqf_no_autoen-flag-in-request_irq.patch
queue-5.10/ntb-intel-fix-the-null-vs-is_err-bug-for-debugfs_cre.patch
queue-5.10/ieee802154-fix-build-error.patch
