This is a note to let you know that I've just added the patch titled debugfs: Convert to new uid/gid option parsing helpers to the 6.10-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: debugfs-convert-to-new-uid-gid-option-parsing-helper.patch and it can be found in the queue-6.10 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. commit 52fe235e918c637b013c3382dc951842c8318ce3 Author: Eric Sandeen <sandeen@xxxxxxxxxx> Date: Thu Jun 27 19:29:46 2024 -0500 debugfs: Convert to new uid/gid option parsing helpers [ Upstream commit 49abee5991e18f14ec822ef53acd173ae58ff594 ] Convert to new uid/gid option parsing helpers Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> Link: https://lore.kernel.org/r/b2f44ee0-3cee-49eb-a416-f26a9306eb56@xxxxxxxxxx Signed-off-by: Christian Brauner <brauner@xxxxxxxxxx> Stable-dep-of: 3a987b88a425 ("debugfs show actual source in /proc/mounts") Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c index 8fd928899a59e..91521576f5003 100644 --- a/fs/debugfs/inode.c +++ b/fs/debugfs/inode.c @@ -92,9 +92,9 @@ enum { }; static const struct fs_parameter_spec debugfs_param_specs[] = { - fsparam_u32 ("gid", Opt_gid), + fsparam_gid ("gid", Opt_gid), fsparam_u32oct ("mode", Opt_mode), - fsparam_u32 ("uid", Opt_uid), + fsparam_uid ("uid", Opt_uid), {} }; @@ -102,8 +102,6 @@ static int debugfs_parse_param(struct fs_context *fc, struct fs_parameter *param { struct debugfs_fs_info *opts = fc->s_fs_info; struct fs_parse_result result; - kuid_t uid; - kgid_t gid; int opt; opt = fs_parse(fc, debugfs_param_specs, param, &result); @@ -120,16 +118,10 @@ static int debugfs_parse_param(struct fs_context *fc, struct fs_parameter *param switch (opt) { case Opt_uid: - uid = make_kuid(current_user_ns(), result.uint_32); - if (!uid_valid(uid)) - return invalf(fc, "Unknown uid"); - opts->uid = uid; + opts->uid = result.uid; break; case Opt_gid: - gid = make_kgid(current_user_ns(), result.uint_32); - if (!gid_valid(gid)) - return invalf(fc, "Unknown gid"); - opts->gid = gid; + opts->gid = result.gid; break; case Opt_mode: opts->mode = result.uint_32 & S_IALLUGO;