Please do not cherry this patch. On 10/01, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > This is a note to let you know that I've just added the patch titled > > Revert "f2fs: use flush command instead of FUA for zoned device" > > to the 6.6-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > revert-f2fs-use-flush-command-instead-of-fua-for-zoned-device.patch > and it can be found in the queue-6.6 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable@xxxxxxxxxxxxxxx> know about it. > > > >From b722ff8ad66cf9beba971d9eb4bb7b5e6265ae5c Mon Sep 17 00:00:00 2001 > From: Wenjie Cheng <cwjhust@xxxxxxxxx> > Date: Fri, 14 Jun 2024 00:48:41 +0000 > Subject: Revert "f2fs: use flush command instead of FUA for zoned device" > > From: Wenjie Cheng <cwjhust@xxxxxxxxx> > > commit b722ff8ad66cf9beba971d9eb4bb7b5e6265ae5c upstream. > > This reverts commit c550e25bca660ed2554cbb48d32b82d0bb98e4b1. > > Commit c550e25bca660ed2554cbb48d32b82d0bb98e4b1 ("f2fs: use flush > command instead of FUA for zoned device") used additional flush > command to keep write order. > > Since Commit dd291d77cc90eb6a86e9860ba8e6e38eebd57d12 ("block: > Introduce zone write plugging") has enabled the block layer to > handle this order issue, there is no need to use flush command. > > Signed-off-by: Wenjie Cheng <cwjhust@xxxxxxxxx> > Reviewed-by: Chao Yu <chao@xxxxxxxxxx> > Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > --- > fs/f2fs/file.c | 3 +-- > fs/f2fs/node.c | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > --- a/fs/f2fs/file.c > +++ b/fs/f2fs/file.c > @@ -371,8 +371,7 @@ sync_nodes: > f2fs_remove_ino_entry(sbi, ino, APPEND_INO); > clear_inode_flag(inode, FI_APPEND_WRITE); > flush_out: > - if ((!atomic && F2FS_OPTION(sbi).fsync_mode != FSYNC_MODE_NOBARRIER) || > - (atomic && !test_opt(sbi, NOBARRIER) && f2fs_sb_has_blkzoned(sbi))) > + if (!atomic && F2FS_OPTION(sbi).fsync_mode != FSYNC_MODE_NOBARRIER) > ret = f2fs_issue_flush(sbi, inode->i_ino); > if (!ret) { > f2fs_remove_ino_entry(sbi, ino, UPDATE_INO); > --- a/fs/f2fs/node.c > +++ b/fs/f2fs/node.c > @@ -1664,7 +1664,7 @@ static int __write_node_page(struct page > goto redirty_out; > } > > - if (atomic && !test_opt(sbi, NOBARRIER) && !f2fs_sb_has_blkzoned(sbi)) > + if (atomic && !test_opt(sbi, NOBARRIER)) > fio.op_flags |= REQ_PREFLUSH | REQ_FUA; > > /* should add to global list before clearing PAGECACHE status */ > > > Patches currently in stable-queue which might be from cwjhust@xxxxxxxxx are > > queue-6.6/revert-f2fs-use-flush-command-instead-of-fua-for-zoned-device.patch
