md: Don't flush sync_work in md_write_start()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Yu Kuai <yukuai3@xxxxxxxxxx>

commit 86ad4cda79e0dade87d4bb0d32e1fe541d4a63e8 upstream.

Because flush sync_work may trigger mddev_suspend() if there are spares,
and this should never be done in IO path because mddev_suspend() is used
to wait for IO.

This problem is found by code review.

Fixes: bc08041b32ab ("md: suspend array in md_start_sync() if array need reconfiguration")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20240801124746.242558-1-yukuai1@xxxxxxxxxxxxxxx
Signed-off-by: Song Liu <song@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
 drivers/md/md.c |    1 -
 1 file changed, 1 deletion(-)

--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -8648,7 +8648,6 @@ void md_write_start(struct mddev *mddev,
 	BUG_ON(mddev->ro == MD_RDONLY);
 	if (mddev->ro == MD_AUTO_READ) {
 		/* need to switch to read/write */
-		flush_work(&mddev->sync_work);
 		mddev->ro = MD_RDWR;
 		set_bit(MD_RECOVERY_NEEDED, &mddev->recovery);
 		md_wakeup_thread(mddev->thread);


Patches currently in stable-queue which might be from yukuai3@xxxxxxxxxx are

queue-6.10/block-bfq-fix-possible-uaf-for-bfqq-bic-with-merge-c.patch
queue-6.10/md-don-t-flush-sync_work-in-md_write_start.patch
queue-6.10/nbd-fix-race-between-timeout-and-normal-completion.patch
queue-6.10/block-bfq-fix-uaf-for-accessing-waker_bfqq-after-spl.patch
queue-6.10/block-bfq-choose-the-last-bfqq-from-merge-chain-in-b.patch
queue-6.10/block-bfq-don-t-break-merge-chain-in-bfq_split_bfqq.patch
queue-6.10/block-bfq-fix-procress-reference-leakage-for-bfqq-in.patch




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux