Hi Greg, On 8/26/24 1:47 PM, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > This is a note to let you know that I've just added the patch titled > > platform/x86: dell-uart-backlight: Use acpi_video_get_backlight_type() > > to the 6.10-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > platform-x86-dell-uart-backlight-use-acpi_video_get_backlight_type.patch > and it can be found in the queue-6.10 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable@xxxxxxxxxxxxxxx> know about it. This patch needs the following commits to actually still allow building the modified driver / fix the bug: cd8e468efb4fb2742e06328a75b282c35c1abf8d 5c7bb62cb8f53de71d8ab3d619be22740da0b837 Note to not break bisecting these 2 need to be applied before upstream commit b5f0943001339c4d324a1af10470ce0bdd79f966. Regards, Hans > From b5f0943001339c4d324a1af10470ce0bdd79f966 Mon Sep 17 00:00:00 2001 > From: Hans de Goede <hdegoede@xxxxxxxxxx> > Date: Wed, 14 Aug 2024 21:01:58 +0200 > Subject: platform/x86: dell-uart-backlight: Use acpi_video_get_backlight_type() > > From: Hans de Goede <hdegoede@xxxxxxxxxx> > > commit b5f0943001339c4d324a1af10470ce0bdd79f966 upstream. > > The dell-uart-backlight driver supports backlight control on Dell All In > One (AIO) models using a backlight controller board connected to an UART. > > In DSDT this uart port will be defined as: > > Name (_HID, "DELL0501") > Name (_CID, EisaId ("PNP0501") > > Now the first AIO has turned up which has not only the DSDT bits for this, > but also an actual controller attached to the UART, yet it is not using > this controller for backlight control. > > Use the acpi_video_get_backlight_type() function from the ACPI video-detect > code to check if the dell-uart-backlight driver should actually be used. > This allows reusing the existing ACPI video-detect infra to override > the backlight control method on the commandline or with DMI quirks. > > Fixes: 484bae9e4d6a ("platform/x86: Add new Dell UART backlight driver") > Cc: All applicable <stable@xxxxxxxxxxxxxxx> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx> > Link: https://patch.msgid.link/20240814190159.15650-3-hdegoede@xxxxxxxxxx > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > --- > drivers/platform/x86/dell/Kconfig | 1 + > drivers/platform/x86/dell/dell-uart-backlight.c | 8 ++++++++ > 2 files changed, 9 insertions(+) > > --- a/drivers/platform/x86/dell/Kconfig > +++ b/drivers/platform/x86/dell/Kconfig > @@ -148,6 +148,7 @@ config DELL_SMO8800 > config DELL_UART_BACKLIGHT > tristate "Dell AIO UART Backlight driver" > depends on ACPI > + depends on ACPI_VIDEO > depends on BACKLIGHT_CLASS_DEVICE > depends on SERIAL_DEV_BUS > help > --- a/drivers/platform/x86/dell/dell-uart-backlight.c > +++ b/drivers/platform/x86/dell/dell-uart-backlight.c > @@ -20,6 +20,7 @@ > #include <linux/string.h> > #include <linux/types.h> > #include <linux/wait.h> > +#include <acpi/video.h> > #include "../serdev_helpers.h" > > /* The backlight controller must respond within 1 second */ > @@ -332,10 +333,17 @@ struct serdev_device_driver dell_uart_bl > > static int dell_uart_bl_pdev_probe(struct platform_device *pdev) > { > + enum acpi_backlight_type bl_type; > struct serdev_device *serdev; > struct device *ctrl_dev; > int ret; > > + bl_type = acpi_video_get_backlight_type(); > + if (bl_type != acpi_backlight_dell_uart) { > + dev_dbg(&pdev->dev, "Not loading (ACPI backlight type = %d)\n", bl_type); > + return -ENODEV; > + } > + > ctrl_dev = get_serdev_controller("DELL0501", NULL, 0, "serial0"); > if (IS_ERR(ctrl_dev)) > return PTR_ERR(ctrl_dev); > > > Patches currently in stable-queue which might be from hdegoede@xxxxxxxxxx are > > queue-6.10/acpi-ec-evaluate-_reg-outside-the-ec-scope-more-carefully.patch > queue-6.10/revert-acpi-ec-evaluate-orphan-_reg-under-ec-device.patch > queue-6.10/acpica-add-a-depth-argument-to-acpi_execute_reg_methods.patch > queue-6.10/platform-x86-dell-uart-backlight-use-acpi_video_get_backlight_type.patch > queue-6.10/usb-misc-ljca-add-lunar-lake-ljca-gpio-hid-to-ljca_gpio_hids.patch > queue-6.10/media-atomisp-fix-streaming-no-longer-working-on-byt-isp2400-devices.patch >
