Patch "selftests: memfd_secret: don't build memfd_secret test on unsupported arches" has been added to the 6.6-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    selftests: memfd_secret: don't build memfd_secret test on unsupported arches

to the 6.6-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     selftests-memfd_secret-don-t-build-memfd_secret-test.patch
and it can be found in the queue-6.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 5feeb82293b6117f33a54470add1c72805524ee0
Author: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
Date:   Fri Aug 9 12:56:42 2024 +0500

    selftests: memfd_secret: don't build memfd_secret test on unsupported arches
    
    [ Upstream commit 7c5e8d212d7d81991a580e7de3904ea213d9a852 ]
    
    [1] mentions that memfd_secret is only supported on arm64, riscv, x86 and
    x86_64 for now.  It doesn't support other architectures.  I found the
    build error on arm and decided to send the fix as it was creating noise on
    KernelCI:
    
    memfd_secret.c: In function 'memfd_secret':
    memfd_secret.c:42:24: error: '__NR_memfd_secret' undeclared (first use in this function);
    did you mean 'memfd_secret'?
       42 |         return syscall(__NR_memfd_secret, flags);
          |                        ^~~~~~~~~~~~~~~~~
          |                        memfd_secret
    
    Hence I'm adding condition that memfd_secret should only be compiled on
    supported architectures.
    
    Also check in run_vmtests script if memfd_secret binary is present before
    executing it.
    
    Link: https://lkml.kernel.org/r/20240812061522.1933054-1-usama.anjum@xxxxxxxxxxxxx
    Link: https://lore.kernel.org/all/20210518072034.31572-7-rppt@xxxxxxxxxx/ [1]
    Link: https://lkml.kernel.org/r/20240809075642.403247-1-usama.anjum@xxxxxxxxxxxxx
    Fixes: 76fe17ef588a ("secretmem: test: add basic selftest for memfd_secret(2)")
    Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
    Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
    Acked-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
    Cc: Albert Ou <aou@xxxxxxxxxxxxxxxxx>
    Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
    Cc: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
    Cc: Palmer Dabbelt <palmer@xxxxxxxxxxx>
    Cc: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
    Cc: <stable@xxxxxxxxxxxxxxx>
    Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/tools/testing/selftests/mm/Makefile b/tools/testing/selftests/mm/Makefile
index 8b2b9bb8bad10..c9fcbc6e5121e 100644
--- a/tools/testing/selftests/mm/Makefile
+++ b/tools/testing/selftests/mm/Makefile
@@ -51,7 +51,9 @@ TEST_GEN_FILES += madv_populate
 TEST_GEN_FILES += map_fixed_noreplace
 TEST_GEN_FILES += map_hugetlb
 TEST_GEN_FILES += map_populate
+ifneq (,$(filter $(ARCH),arm64 riscv riscv64 x86 x86_64))
 TEST_GEN_FILES += memfd_secret
+endif
 TEST_GEN_FILES += migration
 TEST_GEN_FILES += mkdirty
 TEST_GEN_FILES += mlock-random-test
diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh
index 7fae86e482613..d7b2c9d07eec5 100755
--- a/tools/testing/selftests/mm/run_vmtests.sh
+++ b/tools/testing/selftests/mm/run_vmtests.sh
@@ -329,8 +329,11 @@ CATEGORY="hmm" run_test bash ./test_hmm.sh smoke
 # MADV_POPULATE_READ and MADV_POPULATE_WRITE tests
 CATEGORY="madv_populate" run_test ./madv_populate
 
+if [ -x ./memfd_secret ]
+then
 (echo 0 | sudo tee /proc/sys/kernel/yama/ptrace_scope 2>&1) | tap_prefix
 CATEGORY="memfd_secret" run_test ./memfd_secret
+fi
 
 # KSM KSM_MERGE_TIME_HUGE_PAGES test with size of 100
 CATEGORY="ksm" run_test ./ksm_tests -H -s 100




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux