Patch "iommu: Restore lost return in iommu_report_device_fault()" has been added to the 6.10-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    iommu: Restore lost return in iommu_report_device_fault()

to the 6.10-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     iommu-restore-lost-return-in-iommu_report_device_fau.patch
and it can be found in the queue-6.10 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit f14cc7fb69bb4d79d9dfee9ab4678b11ea2cdc84
Author: Barak Biber <bbiber@xxxxxxxxxx>
Date:   Thu Aug 1 09:26:04 2024 -0300

    iommu: Restore lost return in iommu_report_device_fault()
    
    [ Upstream commit fca5b78511e98bdff2cdd55c172b23200a7b3404 ]
    
    When iommu_report_device_fault gets called with a partial fault it is
    supposed to collect the fault into the group and then return.
    
    Instead the return was accidently deleted which results in trying to
    process the fault and an eventual crash.
    
    Deleting the return was a typo, put it back.
    
    Fixes: 3dfa64aecbaf ("iommu: Make iommu_report_device_fault() return void")
    Signed-off-by: Barak Biber <bbiber@xxxxxxxxxx>
    Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxx>
    Reviewed-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
    Link: https://lore.kernel.org/r/0-v1-e7153d9c8cee+1c6-iommu_fault_fix_jgg@xxxxxxxxxx
    Signed-off-by: Joerg Roedel <jroedel@xxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/iommu/io-pgfault.c b/drivers/iommu/io-pgfault.c
index 06d78fcc79fdb..f2c87c695a17c 100644
--- a/drivers/iommu/io-pgfault.c
+++ b/drivers/iommu/io-pgfault.c
@@ -192,6 +192,7 @@ void iommu_report_device_fault(struct device *dev, struct iopf_fault *evt)
 		report_partial_fault(iopf_param, fault);
 		iopf_put_dev_fault_param(iopf_param);
 		/* A request that is not the last does not need to be ack'd */
+		return;
 	}
 
 	/*




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux