On Fri, Aug 16, 2024 at 07:41:31AM -0700, Guenter Roeck wrote: > On 8/16/24 01:49, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > > > This is a note to let you know that I've just added the patch titled > > > > drm/amd/display: Add misc DC changes for DCN401 > > > > to the 6.10-stable tree which can be found at: > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > > > The filename of the patch is: > > drm-amd-display-add-misc-dc-changes-for-dcn401.patch > > and it can be found in the queue-6.10 subdirectory. > > > > If you, or anyone else, feels it should not be added to the stable tree, > > please let <stable@xxxxxxxxxxxxxxx> know about it. > > > > > > > > From 00c391102abc13763e2bfc90e05503109b19f074 Mon Sep 17 00:00:00 2001 > > From: Aurabindo Pillai <aurabindo.pillai@xxxxxxx> > > Date: Wed, 20 Mar 2024 13:56:16 -0400 > > Subject: drm/amd/display: Add misc DC changes for DCN401 > > > > From: Aurabindo Pillai <aurabindo.pillai@xxxxxxx> > > > > commit 00c391102abc13763e2bfc90e05503109b19f074 upstream. > > > > Add miscellaneous changes to enable DCN401 init > > > > Signed-off-by: Aurabindo Pillai <aurabindo.pillai@xxxxxxx> > > Acked-by: Rodrigo Siqueira <rodrigo.siqueira@xxxxxxx> > > Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx> > > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > > [ strip out all of the lunacy in this patch and JUST take the #ifdef > > fix which is needed to fix builds in the 6.10.y tree - gregkh ] > > > That didn't work as intended. > > arm:allmodconfig: > > ERROR: modpost: "pre_validate_dsc" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > ERROR: modpost: "compute_mst_dsc_configs_for_state" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! > > Those are global declarations called from outside the file, so they must not be > part of the #ifdef. argh, ok, let me go run some local builds to try to get this right. Worst case I just revert the original offending commit and let the developers submit something that actually is tested. thanks, greg k-h