Patch "selftests: openvswitch: Set value to nla flags." has been added to the 6.6-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    selftests: openvswitch: Set value to nla flags.

to the 6.6-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     selftests-openvswitch-set-value-to-nla-flags.patch
and it can be found in the queue-6.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 622dd7ce14bd500be1673e085e2a9265db33665a
Author: Adrian Moreno <amorenoz@xxxxxxxxxx>
Date:   Tue Jun 18 09:29:21 2024 +0200

    selftests: openvswitch: Set value to nla flags.
    
    [ Upstream commit a8763466669d21b570b26160d0a5e0a2ee529d22 ]
    
    Netlink flags, although they don't have payload at the netlink level,
    are represented as having "True" as value in pyroute2.
    
    Without it, trying to add a flow with a flag-type action (e.g: pop_vlan)
    fails with the following traceback:
    
    Traceback (most recent call last):
      File "[...]/ovs-dpctl.py", line 2498, in <module>
        sys.exit(main(sys.argv))
                 ^^^^^^^^^^^^^^
      File "[...]/ovs-dpctl.py", line 2487, in main
        ovsflow.add_flow(rep["dpifindex"], flow)
      File "[...]/ovs-dpctl.py", line 2136, in add_flow
        reply = self.nlm_request(
                ^^^^^^^^^^^^^^^^^
      File "[...]/pyroute2/netlink/nlsocket.py", line 822, in nlm_request
        return tuple(self._genlm_request(*argv, **kwarg))
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "[...]/pyroute2/netlink/generic/__init__.py", line 126, in
    nlm_request
        return tuple(super().nlm_request(*argv, **kwarg))
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
      File "[...]/pyroute2/netlink/nlsocket.py", line 1124, in nlm_request
        self.put(msg, msg_type, msg_flags, msg_seq=msg_seq)
      File "[...]/pyroute2/netlink/nlsocket.py", line 389, in put
        self.sendto_gate(msg, addr)
      File "[...]/pyroute2/netlink/nlsocket.py", line 1056, in sendto_gate
        msg.encode()
      File "[...]/pyroute2/netlink/__init__.py", line 1245, in encode
        offset = self.encode_nlas(offset)
                 ^^^^^^^^^^^^^^^^^^^^^^^^
      File "[...]/pyroute2/netlink/__init__.py", line 1560, in encode_nlas
        nla_instance.setvalue(cell[1])
      File "[...]/pyroute2/netlink/__init__.py", line 1265, in setvalue
        nlv.setvalue(nla_tuple[1])
                     ~~~~~~~~~^^^
    IndexError: list index out of range
    
    Signed-off-by: Adrian Moreno <amorenoz@xxxxxxxxxx>
    Acked-by: Aaron Conole <aconole@xxxxxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
index 5e0e539a323d5..8b120718768ec 100644
--- a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
+++ b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py
@@ -531,7 +531,7 @@ class ovsactions(nla):
             for flat_act in parse_flat_map:
                 if parse_starts_block(actstr, flat_act[0], False):
                     actstr = actstr[len(flat_act[0]):]
-                    self["attrs"].append([flat_act[1]])
+                    self["attrs"].append([flat_act[1], True])
                     actstr = actstr[strspn(actstr, ", ") :]
                     parsed = True
 




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux