Patch "nfs: propagate readlink errors in nfs_symlink_filler" has been added to the 6.9-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    nfs: propagate readlink errors in nfs_symlink_filler

to the 6.9-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     nfs-propagate-readlink-errors-in-nfs_symlink_filler.patch
and it can be found in the queue-6.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit f9d2189d2d674a6b4371b16dee2dc4e483c0fd0f
Author: Sagi Grimberg <sagi@xxxxxxxxxxx>
Date:   Tue May 21 15:58:40 2024 +0300

    nfs: propagate readlink errors in nfs_symlink_filler
    
    [ Upstream commit 134d0b3f2440cdddd12fc3444c9c0f62331ce6fc ]
    
    There is an inherent race where a symlink file may have been overriden
    (by a different client) between lookup and readlink, resulting in a
    spurious EIO error returned to userspace. Fix this by propagating back
    ESTALE errors such that the vfs will retry the lookup/get_link (similar
    to nfs4_file_open) at least once.
    
    Cc: Dan Aloni <dan.aloni@xxxxxxxxxxxx>
    Signed-off-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
    Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
    Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/fs/nfs/symlink.c b/fs/nfs/symlink.c
index 0e27a2e4e68b8..13818129d268f 100644
--- a/fs/nfs/symlink.c
+++ b/fs/nfs/symlink.c
@@ -41,7 +41,7 @@ static int nfs_symlink_filler(struct file *file, struct folio *folio)
 error:
 	folio_set_error(folio);
 	folio_unlock(folio);
-	return -EIO;
+	return error;
 }
 
 static const char *nfs_get_link(struct dentry *dentry,




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux