Patch "net: mana: Fix possible double free in error handling path" has been added to the 6.9-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    net: mana: Fix possible double free in error handling path

to the 6.9-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     net-mana-fix-possible-double-free-in-error-handling-.patch
and it can be found in the queue-6.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit a59f016b7c42a74bfd23d53090f7820634eca5b1
Author: Ma Ke <make24@xxxxxxxxxxx>
Date:   Tue Jun 25 21:03:14 2024 +0800

    net: mana: Fix possible double free in error handling path
    
    [ Upstream commit 1864b8224195d0e43ddb92a8151f54f6562090cc ]
    
    When auxiliary_device_add() returns error and then calls
    auxiliary_device_uninit(), callback function adev_release
    calls kfree(madev). We shouldn't call kfree(madev) again
    in the error handling path. Set 'madev' to NULL.
    
    Fixes: a69839d4327d ("net: mana: Add support for auxiliary device")
    Signed-off-by: Ma Ke <make24@xxxxxxxxxxx>
    Link: https://patch.msgid.link/20240625130314.2661257-1-make24@xxxxxxxxxxx
    Signed-off-by: Paolo Abeni <pabeni@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
index d8af5e7e15b4d..191d50ba646d8 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -2800,6 +2800,8 @@ static int add_adev(struct gdma_dev *gd)
 	if (ret)
 		goto init_fail;
 
+	/* madev is owned by the auxiliary device */
+	madev = NULL;
 	ret = auxiliary_device_add(adev);
 	if (ret)
 		goto add_fail;




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux