Patch "RDMA/rxe: Fix responder length checking for UD request packets" has been added to the 6.6-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    RDMA/rxe: Fix responder length checking for UD request packets

to the 6.6-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     rdma-rxe-fix-responder-length-checking-for-ud-reques.patch
and it can be found in the queue-6.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 22d5521708f3c775d3b9b6331bb707d26e31f29e
Author: Honggang LI <honggangli@xxxxxxx>
Date:   Thu May 23 17:46:17 2024 +0800

    RDMA/rxe: Fix responder length checking for UD request packets
    
    [ Upstream commit f67ac0061c7614c1548963d3ef1ee1606efd8636 ]
    
    According to the IBA specification:
    If a UD request packet is detected with an invalid length, the request
    shall be an invalid request and it shall be silently dropped by
    the responder. The responder then waits for a new request packet.
    
    commit 689c5421bfe0 ("RDMA/rxe: Fix incorrect responder length checking")
    defers responder length check for UD QPs in function `copy_data`.
    But it introduces a regression issue for UD QPs.
    
    When the packet size is too large to fit in the receive buffer.
    `copy_data` will return error code -EINVAL. Then `send_data_in`
    will return RESPST_ERR_MALFORMED_WQE. UD QP will transfer into
    ERROR state.
    
    Fixes: 689c5421bfe0 ("RDMA/rxe: Fix incorrect responder length checking")
    Signed-off-by: Honggang LI <honggangli@xxxxxxx>
    Link: https://lore.kernel.org/r/20240523094617.141148-1-honggangli@xxxxxxx
    Reviewed-by: Zhu Yanjun <yanjun.zhu@xxxxxxxxx>
    Signed-off-by: Leon Romanovsky <leon@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/infiniband/sw/rxe/rxe_resp.c b/drivers/infiniband/sw/rxe/rxe_resp.c
index da470a925efc7..c02aa27fe5d81 100644
--- a/drivers/infiniband/sw/rxe/rxe_resp.c
+++ b/drivers/infiniband/sw/rxe/rxe_resp.c
@@ -354,6 +354,19 @@ static enum resp_states rxe_resp_check_length(struct rxe_qp *qp,
 	 * receive buffer later. For rmda operations additional
 	 * length checks are performed in check_rkey.
 	 */
+	if ((qp_type(qp) == IB_QPT_GSI) || (qp_type(qp) == IB_QPT_UD)) {
+		unsigned int payload = payload_size(pkt);
+		unsigned int recv_buffer_len = 0;
+		int i;
+
+		for (i = 0; i < qp->resp.wqe->dma.num_sge; i++)
+			recv_buffer_len += qp->resp.wqe->dma.sge[i].length;
+		if (payload + 40 > recv_buffer_len) {
+			rxe_dbg_qp(qp, "The receive buffer is too small for this UD packet.\n");
+			return RESPST_ERR_LENGTH;
+		}
+	}
+
 	if (pkt->mask & RXE_PAYLOAD_MASK && ((qp_type(qp) == IB_QPT_RC) ||
 					     (qp_type(qp) == IB_QPT_UC))) {
 		unsigned int mtu = qp->mtu;




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux