From: Po-Hsu Lin <po-hsu.lin@xxxxxxxxxxxxx> From: Benjamin Poirier <bpoirier@xxxxxxxxxx> commit 06efafd8608dac0c3a480539acc66ee41d2fb430 upstream. Some scripts are not tests themselves; they contain utility functions used by other tests. According to Documentation/dev-tools/kselftest.rst, such files should be listed in TEST_FILES. Move those utility scripts to TEST_FILES. Fixes: 1751eb42ddb5 ("selftests: net: use TEST_PROGS_EXTENDED") Fixes: 25ae948b4478 ("selftests/net: add lib.sh") Fixes: b99ac1841147 ("kselftests/net: add missed setup_loopback.sh/setup_veth.sh to Makefile") Fixes: f5173fe3e13b ("selftests: net: included needed helper in the install targets") Suggested-by: Petr Machata <petrm@xxxxxxxxxx> Signed-off-by: Benjamin Poirier <bpoirier@xxxxxxxxxx> Link: https://lore.kernel.org/r/20240131140848.360618-5-bpoirier@xxxxxxxxxx Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> [PHLin: ignore the non-existing lib.sh] Signed-off-by: Po-Hsu Lin <po-hsu.lin@xxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- tools/testing/selftests/net/Makefile | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- a/tools/testing/selftests/net/Makefile +++ b/tools/testing/selftests/net/Makefile @@ -53,9 +53,7 @@ TEST_PROGS += bind_bhash.sh TEST_PROGS += ip_local_port_range.sh TEST_PROGS += rps_default_mask.sh TEST_PROGS += big_tcp.sh -TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh -TEST_PROGS_EXTENDED += toeplitz_client.sh toeplitz.sh -TEST_PROGS_EXTENDED += net_helper.sh +TEST_PROGS_EXTENDED := toeplitz_client.sh toeplitz.sh TEST_GEN_FILES = socket nettest TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy reuseport_addr_any TEST_GEN_FILES += tcp_mmap tcp_inq psock_snd txring_overwrite @@ -94,6 +92,7 @@ TEST_PROGS += test_vxlan_nolocalbypass.s TEST_PROGS += test_bridge_backup_port.sh TEST_FILES := settings +TEST_FILES += in_netns.sh net_helper.sh setup_loopback.sh setup_veth.sh include ../lib.mk Patches currently in stable-queue which might be from kroah.com@xxxxxxxxxxxxxxx are queue-6.6/selftests-net-included-needed-helper-in-the-install-targets.patch queue-6.6/selftests-net-synchronize-udpgro-tests-tx-and-rx-connection.patch queue-6.6/selftests-net-list-helper-scripts-in-test_files-makefile-variable.patch queue-6.6/mptcp-fix-full-tcp-keep-alive-support.patch queue-6.6/mptcp-cleanup-sol_tcp-handling.patch queue-6.6/mptcp-avoid-some-duplicate-code-in-socket-option-handling.patch