From: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>
commit 84a8bc3ec225b28067b168e9410e452c83d706da upstream.
Without this, the 'i' variable declared before could be overridden by
accident, e.g.
for i in "${@}"; do
__ksft_status_merge "${i}" ## 'i' has been modified
foo "${i}" ## using 'i' with an unexpected value
done
After a quick look, it looks like 'i' is currently not used after having
been modified in __ksft_status_merge(), but still, better be safe than
sorry. I saw this while modifying the same file, not because I suspected
an issue somewhere.
Fixes: 596c8819cb78 ("selftests: forwarding: Have RET track kselftest framework constants")
Acked-by: Geliang Tang <geliang@xxxxxxxxxx>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@xxxxxxxxxx>
Reviewed-by: Hangbin Liu <liuhangbin@xxxxxxxxx>
Link: https://lore.kernel.org/r/20240605-upstream-net-20240605-selftests-net-lib-fixes-v1-3-b3afadd368c9@xxxxxxxxxx
Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
tools/testing/selftests/net/lib.sh | 1 +
1 file changed, 1 insertion(+)
--- a/tools/testing/selftests/net/lib.sh
+++ b/tools/testing/selftests/net/lib.sh
@@ -22,6 +22,7 @@ __ksft_status_merge()
local -A weights
local weight=0
+ local i
for i in "$@"; do
weights[$i]=$((weight++))
done
Patches currently in stable-queue which might be from matttbe@xxxxxxxxxx are
queue-6.9/selftests-mptcp-add-ms-units-for-tc-netem-delay.patch
queue-6.9/selftests-mptcp-join-mark-fail-tests-as-flaky.patch
queue-6.9/selftests-net-lib-set-i-as-local.patch
queue-6.9/selftests-mptcp-join-mark-fastclose-tests-as-flaky.patch
queue-6.9/selftests-mptcp-simult-flows-mark-unbalanced-tests-a.patch
