Patch "netfs: Fix setting of BDP_ASYNC from iocb flags" has been added to the 6.8-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    netfs: Fix setting of BDP_ASYNC from iocb flags

to the 6.8-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     netfs-fix-setting-of-bdp_async-from-iocb-flags.patch
and it can be found in the queue-6.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 316923e2a9fd0224f920b3b5b2fc1f7540a39ee1
Author: David Howells <dhowells@xxxxxxxxxx>
Date:   Tue May 21 16:49:46 2024 +0100

    netfs: Fix setting of BDP_ASYNC from iocb flags
    
    [ Upstream commit c596bea1452ddf172ec9b588e4597228e9a1f4d5 ]
    
    Fix netfs_perform_write() to set BDP_ASYNC if IOCB_NOWAIT is set rather
    than if IOCB_SYNC is not set.  It reflects asynchronicity in the sense of
    not waiting rather than synchronicity in the sense of not returning until
    the op is complete.
    
    Without this, generic/590 fails on cifs in strict caching mode with a
    complaint that one of the writes fails with EAGAIN.  The test can be
    distilled down to:
    
            mount -t cifs /my/share /mnt -ostuff
            xfs_io -i -c 'falloc 0 8191M -c fsync -f /mnt/file
            xfs_io -i -c 'pwrite -b 1M -W 0 8191M' /mnt/file
    
    Fixes: c38f4e96e605 ("netfs: Provide func to copy data to pagecache for buffered write")
    Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
    Link: https://lore.kernel.org/r/316306.1716306586@xxxxxxxxxxxxxxxxxxxxxx
    Reviewed-by: Jens Axboe <axboe@xxxxxxxxx>
    cc: Jeff Layton <jlayton@xxxxxxxxxx>
    cc: Enzo Matsumiya <ematsumiya@xxxxxxx>
    cc: Jens Axboe <axboe@xxxxxxxxx>
    cc: Matthew Wilcox <willy@xxxxxxxxxxxxx>
    cc: netfs@xxxxxxxxxxxxxxx
    cc: v9fs@xxxxxxxxxxxxxxx
    cc: linux-afs@xxxxxxxxxxxxxxxxxxx
    cc: linux-cifs@xxxxxxxxxxxxxxx
    cc: linux-fsdevel@xxxxxxxxxxxxxxx
    Signed-off-by: Christian Brauner <brauner@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c
index 267b622d923b1..912ad0a1df021 100644
--- a/fs/netfs/buffered_write.c
+++ b/fs/netfs/buffered_write.c
@@ -163,7 +163,7 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter,
 	struct folio *folio;
 	enum netfs_how_to_modify howto;
 	enum netfs_folio_trace trace;
-	unsigned int bdp_flags = (iocb->ki_flags & IOCB_SYNC) ? 0: BDP_ASYNC;
+	unsigned int bdp_flags = (iocb->ki_flags & IOCB_NOWAIT) ? BDP_ASYNC : 0;
 	ssize_t written = 0, ret, ret2;
 	loff_t i_size, pos = iocb->ki_pos, from, to;
 	size_t max_chunk = PAGE_SIZE << MAX_PAGECACHE_ORDER;




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux