Patch "mailbox: mtk-cmdq: Fix pm_runtime_get_sync() warning in mbox shutdown" has been added to the 6.8-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    mailbox: mtk-cmdq: Fix pm_runtime_get_sync() warning in mbox shutdown

to the 6.8-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     mailbox-mtk-cmdq-fix-pm_runtime_get_sync-warning-in-.patch
and it can be found in the queue-6.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 6dd31c0015c838f1eb5385854b18161490565b3b
Author: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>
Date:   Fri Apr 26 10:01:21 2024 +0800

    mailbox: mtk-cmdq: Fix pm_runtime_get_sync() warning in mbox shutdown
    
    [ Upstream commit 747a69a119c469121385543f21c2d08562968ccc ]
    
    The return value of pm_runtime_get_sync() in cmdq_mbox_shutdown()
    will return 1 when pm runtime state is active, and we don't want to
    get the warning message in this case.
    
    So we change the return value < 0 for WARN_ON().
    
    Fixes: 8afe816b0c99 ("mailbox: mtk-cmdq-mailbox: Implement Runtime PM with autosuspend")
    Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>
    Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
    Signed-off-by: Jassi Brar <jassisinghbrar@xxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index ead2200f39ba0..033aff11f87cf 100644
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -465,7 +465,7 @@ static void cmdq_mbox_shutdown(struct mbox_chan *chan)
 	struct cmdq_task *task, *tmp;
 	unsigned long flags;
 
-	WARN_ON(pm_runtime_get_sync(cmdq->mbox.dev));
+	WARN_ON(pm_runtime_get_sync(cmdq->mbox.dev) < 0);
 
 	spin_lock_irqsave(&thread->chan->lock, flags);
 	if (list_empty(&thread->task_busy_list))




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux