Patch "idpf: don't skip over ethtool tcp-data-split setting" has been added to the 6.8-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    idpf: don't skip over ethtool tcp-data-split setting

to the 6.8-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     idpf-don-t-skip-over-ethtool-tcp-data-split-setting.patch
and it can be found in the queue-6.8 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit ee0c64df3b188a089ce105749641dfa59f69e234
Author: Michal Schmidt <mschmidt@xxxxxxxxxx>
Date:   Wed May 15 11:24:14 2024 +0200

    idpf: don't skip over ethtool tcp-data-split setting
    
    [ Upstream commit 67708158e732bf03d076fba1e3d4453fbf8292a2 ]
    
    Disabling tcp-data-split on idpf silently fails:
      # ethtool -G $NETDEV tcp-data-split off
      # ethtool -g $NETDEV | grep 'TCP data split'
      TCP data split:        on
    
    But it works if you also change 'tx' or 'rx':
      # ethtool -G $NETDEV tcp-data-split off tx 256
      # ethtool -g $NETDEV | grep 'TCP data split'
      TCP data split:        off
    
    The bug is in idpf_set_ringparam, where it takes a shortcut out if the
    TX and RX sizes are not changing. Fix it by checking also if the
    tcp-data-split setting remains unchanged. Only then can the soft reset
    be skipped.
    
    Fixes: 9b1aa3ef2328 ("idpf: add get/set for Ethtool's header split ringparam")
    Reported-by: Xu Du <xudu@xxxxxxxxxx>
    Closes: https://issues.redhat.com/browse/RHEL-36182
    Signed-off-by: Michal Schmidt <mschmidt@xxxxxxxxxx>
    Reviewed-by: Alexander Lobakin <aleksander.lobakin@xxxxxxxxx>
    Link: https://lore.kernel.org/r/20240515092414.158079-1-mschmidt@xxxxxxxxxx
    Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
index 986d429d11755..6972d728431cb 100644
--- a/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
+++ b/drivers/net/ethernet/intel/idpf/idpf_ethtool.c
@@ -376,7 +376,8 @@ static int idpf_set_ringparam(struct net_device *netdev,
 			    new_tx_count);
 
 	if (new_tx_count == vport->txq_desc_count &&
-	    new_rx_count == vport->rxq_desc_count)
+	    new_rx_count == vport->rxq_desc_count &&
+	    kring->tcp_data_split == idpf_vport_get_hsplit(vport))
 		goto unlock_mutex;
 
 	if (!idpf_vport_set_hsplit(vport, kring->tcp_data_split)) {




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux