This is a note to let you know that I've just added the patch titled
pinctrl: mediatek: paris: Fix PIN_CONFIG_INPUT_SCHMITT_ENABLE readback
to the 5.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
pinctrl-mediatek-paris-fix-pin_config_input_schmitt_enable-readback.patch
and it can be found in the queue-5.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 08f66a8edd08f6f7cfa769c81634b29a2b123908 Mon Sep 17 00:00:00 2001
From: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
Date: Wed, 27 Mar 2024 17:13:33 +0800
Subject: pinctrl: mediatek: paris: Fix PIN_CONFIG_INPUT_SCHMITT_ENABLE readback
From: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
commit 08f66a8edd08f6f7cfa769c81634b29a2b123908 upstream.
In the generic pin config library, readback of some options are handled
differently compared to the setting of those options: the argument value
is used to convey enable/disable of an option in the set path, but
success or -EINVAL is used to convey if an option is enabled or disabled
in the debugfs readback path.
PIN_CONFIG_INPUT_SCHMITT_ENABLE is one such option. Fix the readback of
the option in the mediatek-paris library, so that the debugfs dump is
not showing "input schmitt enabled" for pins that don't have it enabled.
Fixes: 1bea6afbc842 ("pinctrl: mediatek: Refine mtk_pinconf_get()")
Signed-off-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
Message-ID: <20240327091336.3434141-2-wenst@xxxxxxxxxxxx>
Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/pinctrl/mediatek/pinctrl-paris.c | 2 ++
1 file changed, 2 insertions(+)
--- a/drivers/pinctrl/mediatek/pinctrl-paris.c
+++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
@@ -141,6 +141,8 @@ static int mtk_pinconf_get(struct pinctr
}
err = mtk_hw_get_value(hw, desc, PINCTRL_PIN_REG_SMT, &ret);
+ if (!ret)
+ err = -EINVAL;
break;
case PIN_CONFIG_DRIVE_STRENGTH:
if (!hw->soc->drive_get)
Patches currently in stable-queue which might be from wenst@xxxxxxxxxxxx are
queue-5.4/pinctrl-mediatek-fix-fallback-behavior-for-bias_set_combo.patch
queue-5.4/pinctrl-mediatek-paris-rework-support-for-pin_config.patch
queue-5.4/pinctrl-mediatek-paris-fix-pin_config_bias_-readback.patch
queue-5.4/pinctrl-mediatek-paris-fix-pin_config_input_schmitt_enable-readback.patch
queue-5.4/pinctrl-mediatek-paris-rework-mtk_pinconf_-get-set-s.patch
