On 5/7/24 9:08 AM, Uwe Kleine-König wrote:
> Hello David,
>
> On Tue, May 07, 2024 at 08:59:16AM -0500, David Lechner wrote:
>> On 5/7/24 1:13 AM, Uwe Kleine-König wrote:
>>> On Mon, May 06, 2024 at 03:43:47PM -0500, David Lechner wrote:
>>>> Does not meet the criteria for stable.
>>>
>>> It was identified as a dependency of another patch. But I agree to
>>> David, it should be trivial to back this patch out. If you need help,
>>> please tell me.
>>>
>>
>> The "fix" patch isn't something that should be backported to stable
>> either, so we shouldn't need to do anything here other than drop
>> the whole series from the stable queue.
>
> Maybe it's just me, but for me backporting commit 0064db9ce4aa ("spi:
> axi-spi-engine: fix version format string") looks sensible. (Or what do
> you mean with "the \"fix\" patch"?) It's a small fix for a small
> annoyance, but looks harmless enough that I'd tend to include it in
> stable.
>
It's just fixing a theoretical problem, not one that has actually
caused problems for people. The stable guidelines I read [1] said we
shouldn't include fixes like that.
[1]: https://docs.kernel.org/process/stable-kernel-rules.html
So, sure it would probably be harmless to include it without the
other dependencies. But not sure it is worth the effort for only
a theoretical problem.
