On Mon, Apr 29, 2024 at 02:51:59PM +0200, Johannes Berg wrote: > On Mon, 2024-04-29 at 12:43 +0000, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > This is a note to let you know that I've just added the patch titled > > > > wifi: nl80211: don't free NULL coalescing rule > > [snip] > > > --- a/net/wireless/nl80211.c > > +++ b/net/wireless/nl80211.c > > @@ -14092,6 +14092,8 @@ static int nl80211_set_coalesce(struct s > > error: > > for (i = 0; i < new_coalesce.n_rules; i++) { > > tmp_rule = &new_coalesce.rules[i]; > > + if (!tmp_rule) > > + continue; > > I don't know why I got this so utterly this wrong, but of course this > just adds dead code. Please drop it from all stable queues. > > I've got a further change to this in the pipeline anyway, I'll drop the > dead check there again. Dropped from all queues now, thanks. greg k-h