On Mon, Apr 29, 2024 at 01:46:24PM +0200, Greg Kroah-Hartman wrote: > > This is a note to let you know that I've just added the patch titled > > Bluetooth: qca: fix invalid device address check > > to the 6.8-stable tree which can be found at: > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary > > The filename of the patch is: > bluetooth-qca-fix-invalid-device-address-check.patch > and it can be found in the queue-6.8 subdirectory. > > If you, or anyone else, feels it should not be added to the stable tree, > please let <stable@xxxxxxxxxxxxxxx> know about it. > > > From 32868e126c78876a8a5ddfcb6ac8cb2fffcf4d27 Mon Sep 17 00:00:00 2001 > From: Johan Hovold <johan+linaro@xxxxxxxxxx> > Date: Tue, 16 Apr 2024 11:15:09 +0200 > Subject: Bluetooth: qca: fix invalid device address check > > From: Johan Hovold <johan+linaro@xxxxxxxxxx> > > commit 32868e126c78876a8a5ddfcb6ac8cb2fffcf4d27 upstream. > > Qualcomm Bluetooth controllers may not have been provisioned with a > valid device address and instead end up using the default address > 00:00:00:00:5a:ad. > > This was previously believed to be due to lack of persistent storage for > the address but it may also be due to integrators opting to not use the > on-chip OTP memory and instead store the address elsewhere (e.g. in > storage managed by secure world firmware). > > According to Qualcomm, at least WCN6750, WCN6855 and WCN7850 have > on-chip OTP storage for the address. > > As the device type alone cannot be used to determine when the address is > valid, instead read back the address during setup() and only set the > HCI_QUIRK_USE_BDADDR_PROPERTY flag when needed. > > This specifically makes sure that controllers that have been provisioned > with an address do not start as unconfigured. > > Reported-by: Janaki Ramaiah Thota <quic_janathot@xxxxxxxxxxx> > Link: https://lore.kernel.org/r/124a7d54-5a18-4be7-9a76-a12017f6cce5@xxxxxxxxxxx/ > Fixes: 5971752de44c ("Bluetooth: hci_qca: Set HCI_QUIRK_USE_BDADDR_PROPERTY for wcn3990") > Fixes: e668eb1e1578 ("Bluetooth: hci_core: Don't stop BT if the BD address missing in dts") > Fixes: 6945795bc81a ("Bluetooth: fix use-bdaddr-property quirk") > Cc: stable@xxxxxxxxxxxxxxx # 6.5 > Cc: Matthias Kaehlcke <mka@xxxxxxxxxxxx> > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > Reported-by: Janaki Ramaiah Thota <quic_janathot@xxxxxxxxxxx> > Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@xxxxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Greg, can you hold off on backporting this one a bit? We need a follow-up patch to avoid regressing some Chromebooks so these patches need to be backported together. I'll send you the backports when everything's in place. Johan
