This is a note to let you know that I've just added the patch titled
Revert "usb: cdc-wdm: close race between read and workqueue"
to the 6.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
revert-usb-cdc-wdm-close-race-between-read-and-workqueue.patch
and it can be found in the queue-6.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 1607830dadeefc407e4956336d9fcd9e9defd810 Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 18 Apr 2024 16:33:28 +0200
Subject: Revert "usb: cdc-wdm: close race between read and workqueue"
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
commit 1607830dadeefc407e4956336d9fcd9e9defd810 upstream.
This reverts commit 339f83612f3a569b194680768b22bf113c26a29d.
It has been found to cause problems in a number of Chromebook devices,
so revert the change until it can be brought back in a safe way.
Link: https://lore.kernel.org/r/385a3519-b45d-48c5-a6fd-a3fdb6bec92f@xxxxxxxxxxxx
Reported-by:: Aleksander Morgado <aleksandermj@xxxxxxxxxxxx>
Fixes: 339f83612f3a ("usb: cdc-wdm: close race between read and workqueue")
Cc: stable <stable@xxxxxxxxxx>
Cc: Oliver Neukum <oneukum@xxxxxxxx>
Cc: Bjørn Mork <bjorn@xxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/usb/class/cdc-wdm.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
--- a/drivers/usb/class/cdc-wdm.c
+++ b/drivers/usb/class/cdc-wdm.c
@@ -485,7 +485,6 @@ out_free_mem:
static int service_outstanding_interrupt(struct wdm_device *desc)
{
int rv = 0;
- int used;
/* submit read urb only if the device is waiting for it */
if (!desc->resp_count || !--desc->resp_count)
@@ -500,10 +499,7 @@ static int service_outstanding_interrupt
goto out;
}
- used = test_and_set_bit(WDM_RESPONDING, &desc->flags);
- if (used)
- goto out;
-
+ set_bit(WDM_RESPONDING, &desc->flags);
spin_unlock_irq(&desc->iuspin);
rv = usb_submit_urb(desc->response, GFP_KERNEL);
spin_lock_irq(&desc->iuspin);
Patches currently in stable-queue which might be from gregkh@xxxxxxxxxxxxxxxxxxx are
queue-6.1/x86-boot-drop-pe-coff-.reloc-section.patch
queue-6.1/thunderbolt-avoid-notify-pm-core-about-runtime-pm-resume.patch
queue-6.1/kvm-x86-pmu-do-not-mask-lvtpc-when-handling-a-pmi-on-amd-platforms.patch
queue-6.1/comedi-vmk80xx-fix-incomplete-endpoint-checking.patch
queue-6.1/arm64-hibernate-fix-level3-translation-fault-in-swsusp_save.patch
queue-6.1/usb-serial-option-add-support-for-fibocom-fm650-fg650.patch
queue-6.1/net-usb-ax88179_178a-avoid-writing-the-mac-address-before-first-reading.patch
queue-6.1/usb-serial-option-add-telit-fn920c04-rmnet-compositions.patch
queue-6.1/x86-sme-move-early-sme-kernel-encryption-handling-into-.head.text.patch
queue-6.1/usb-new-quirk-to-reduce-the-set_address-request-time.patch
queue-6.1/usb-dwc2-host-fix-dereference-issue-in-ddma-completion-flow.patch
queue-6.1/usb-xhci-add-timeout-argument-in-address_device-usb-.patch
queue-6.1/x86-boot-omit-compression-buffer-from-pe-coff-image-memory-footprint.patch
queue-6.1/x86-mm-remove-p-d_page_mask-and-p-d_page_size-macros.patch
queue-6.1/drm-i915-vma-fix-uaf-on-destroy-against-retire-race.patch
queue-6.1/selftests-ftrace-limit-length-in-subsystem-enable-tests.patch
queue-6.1/x86-efi-drop-alignment-flags-from-pe-section-headers.patch
queue-6.1/x86-boot-increase-section-and-file-alignment-to-4k-512.patch
queue-6.1/x86-head-64-add-missing-__head-annotation-to-startup_64_load_idt.patch
queue-6.1/random-handle-creditable-entropy-from-atomic-process-context.patch
queue-6.1/x86-boot-define-setup-size-in-linker-script.patch
queue-6.1/usb-serial-option-add-fibocom-fm135-gl-variants.patch
queue-6.1/serial-stm32-return-irq_none-in-the-isr-if-no-handling-happend.patch
queue-6.1/mm-memory-failure-fix-deadlock-when-hugetlb_optimize_vmemmap-is-enabled.patch
queue-6.1/x86-boot-split-off-pe-coff-.data-section.patch
queue-6.1/x86-boot-derive-file-size-from-_edata-symbol.patch
queue-6.1/init-main.c-fix-potential-static_command_line-memory-overflow.patch
queue-6.1/x86-boot-construct-pe-coff-.text-section-from-assembler.patch
queue-6.1/x86-boot-grab-kernel_info-offset-from-zoffset-header-directly.patch
queue-6.1/speakup-avoid-crash-on-very-long-word.patch
queue-6.1/usb-disable-usb3-lpm-at-shutdown.patch
queue-6.1/thunderbolt-fix-wake-configurations-after-device-unplug.patch
queue-6.1/x86-sev-move-early-startup-code-into-.head.text-section.patch
queue-6.1/kvm-x86-snapshot-if-a-vcpu-s-vendor-model-is-amd-vs.-intel-compatible.patch
queue-6.1/x86-boot-remove-the-bugger-off-message.patch
queue-6.1/x86-head-64-move-the-__head-definition-to-asm-init.h.patch
queue-6.1/x86-boot-drop-references-to-startup_64.patch
queue-6.1/serial-pmac_zilog-remove-flawed-mitigation-for-rx-irq-flood.patch
queue-6.1/x86-efistub-use-1-1-file-memory-mapping-for-pe-coff-.compat-section.patch
queue-6.1/x86-efi-drop-efi-stub-.bss-from-.data-section.patch
queue-6.1/io_uring-fix-io_cqring_wait-not-restoring-sigmask-on-get_timespec64-failure.patch
queue-6.1/usb-pci-quirks-group-amd-specific-quirk-code-togethe.patch
queue-6.1/usb-serial-option-add-lonsung-u8300-u9300-product.patch
queue-6.1/x86-efi-disregard-setup-header-of-loaded-image.patch
queue-6.1/usb-serial-option-support-quectel-em060k-sub-models.patch
queue-6.1/kvm-x86-pmu-disable-support-for-adaptive-pebs.patch
queue-6.1/usb-gadget-f_ncm-fix-uaf-ncm-object-at-re-bind-after-usb-ep-transport-error.patch
queue-6.1/x86-efistub-remap-kernel-text-read-only-before-dropping-nx-attribute.patch
queue-6.1/serial-mxs-auart-add-spinlock-around-changing-cts-state.patch
queue-6.1/fs-sysfs-fix-reference-leak-in-sysfs_break_active_protection.patch
queue-6.1/x86-efistub-reinstate-soft-limit-for-initrd-loading.patch
queue-6.1/alsa-hda-realtek-enable-audio-jacks-of-haier-boyue-g42-with-alc269vc.patch
queue-6.1/x86-boot-set-efi-handover-offset-directly-in-header-asm.patch
queue-6.1/binder-check-offset-alignment-in-binder_get_object.patch
queue-6.1/serial-stm32-reset-.throttled-state-in-.startup.patch
queue-6.1/revert-usb-cdc-wdm-close-race-between-read-and-workqueue.patch
queue-6.1/usb-pci-quirks-reduce-the-length-of-a-spinlock-secti.patch
queue-6.1/usb-serial-option-add-rolling-rw101-gl-and-rw135-gl-support.patch
queue-6.1/x86-boot-drop-redundant-code-setting-the-root-device.patch
queue-6.1/sunrpc-fix-rpcgss_context-trace-event-acceptor-field.patch
queue-6.1/mei-me-disable-rpl-s-on-sps-and-ign-firmwares.patch
