This is a note to let you know that I've just added the patch titled
x86/retpoline: Add NOENDBR annotation to the SRSO dummy return thunk
to the 5.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
x86-retpoline-add-noendbr-annotation-to-the-srso-dummy-return-thunk.patch
and it can be found in the queue-5.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From b377c66ae3509ccea596512d6afb4777711c4870 Mon Sep 17 00:00:00 2001
From: "Borislav Petkov (AMD)" <bp@xxxxxxxxx>
Date: Fri, 5 Apr 2024 16:46:37 +0200
Subject: x86/retpoline: Add NOENDBR annotation to the SRSO dummy return thunk
From: Borislav Petkov (AMD) <bp@xxxxxxxxx>
commit b377c66ae3509ccea596512d6afb4777711c4870 upstream.
srso_alias_untrain_ret() is special code, even if it is a dummy
which is called in the !SRSO case, so annotate it like its real
counterpart, to address the following objtool splat:
vmlinux.o: warning: objtool: .export_symbol+0x2b290: data relocation to !ENDBR: srso_alias_untrain_ret+0x0
Fixes: 4535e1a4174c ("x86/bugs: Fix the SRSO mitigation on Zen3/4")
Signed-off-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20240405144637.17908-1-bp@xxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
arch/x86/lib/retpoline.S | 1 +
1 file changed, 1 insertion(+)
--- a/arch/x86/lib/retpoline.S
+++ b/arch/x86/lib/retpoline.S
@@ -258,6 +258,7 @@ SYM_CODE_START(__x86_return_thunk)
UNWIND_HINT_FUNC
ANNOTATE_NOENDBR
ANNOTATE_UNRET_SAFE
+ ANNOTATE_NOENDBR
ret
int3
SYM_CODE_END(__x86_return_thunk)
Patches currently in stable-queue which might be from bp@xxxxxxxxx are
queue-5.10/x86-cpu-amd-update-the-zenbleed-microcode-revisions.patch
queue-5.10/x86-retpoline-add-noendbr-annotation-to-the-srso-dummy-return-thunk.patch
queue-5.10/x86-cpu-support-amd-automatic-ibrs.patch
queue-5.10/x86-srso-add-srso-mitigation-for-hygon-processors.patch
queue-5.10/x86-bugs-use-sysfs_emit.patch
queue-5.10/x86-bugs-fix-the-srso-mitigation-on-zen3-4.patch
queue-5.10/x86-mce-make-sure-to-grab-mce_sysfs_mutex-in-set_bank.patch
queue-5.10/x86-retpoline-do-the-necessary-fixup-to-the-zen3-4-srso-return-thunk-for-srso.patch
queue-5.10/x86-cpu-enable-stibp-on-amd-if-automatic-ibrs-is-enabled.patch
queue-5.10/x86-mm-pat-fix-vm_pat-handling-in-cow-mappings.patch
