This is a note to let you know that I've just added the patch titled
selftests: reuseaddr_conflict: add missing new line at the end of the output
to the 5.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
selftests-reuseaddr_conflict-add-missing-new-line-at-the-end-of-the-output.patch
and it can be found in the queue-5.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 31974122cfdeaf56abc18d8ab740d580d9833e90 Mon Sep 17 00:00:00 2001
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Fri, 29 Mar 2024 09:05:59 -0700
Subject: selftests: reuseaddr_conflict: add missing new line at the end of the output
From: Jakub Kicinski <kuba@xxxxxxxxxx>
commit 31974122cfdeaf56abc18d8ab740d580d9833e90 upstream.
The netdev CI runs in a VM and captures serial, so stdout and
stderr get combined. Because there's a missing new line in
stderr the test ends up corrupting KTAP:
# Successok 1 selftests: net: reuseaddr_conflict
which should have been:
# Success
ok 1 selftests: net: reuseaddr_conflict
Fixes: 422d8dc6fd3a ("selftest: add a reuseaddr test")
Reviewed-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20240329160559.249476-1-kuba@xxxxxxxxxx
Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
tools/testing/selftests/net/reuseaddr_conflict.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/tools/testing/selftests/net/reuseaddr_conflict.c
+++ b/tools/testing/selftests/net/reuseaddr_conflict.c
@@ -109,6 +109,6 @@ int main(void)
fd1 = open_port(0, 1);
if (fd1 >= 0)
error(1, 0, "Was allowed to create an ipv4 reuseport on an already bound non-reuseport socket with no ipv6");
- fprintf(stderr, "Success");
+ fprintf(stderr, "Success\n");
return 0;
}
Patches currently in stable-queue which might be from kuba@xxxxxxxxxx are
queue-5.4/ipv6-fix-infinite-recursion-in-fib6_dump_done.patch
queue-5.4/tcp-properly-terminate-timers-for-kernel-sockets.patch
queue-5.4/selftests-reuseaddr_conflict-add-missing-new-line-at-the-end-of-the-output.patch
queue-5.4/net-sched-act_skbmod-prevent-kernel-infoleak.patch
queue-5.4/net-stmmac-fix-rx-queue-priority-assignment.patch
queue-5.4/net-rds-fix-possible-cp-null-dereference.patch
queue-5.4/r8169-fix-issue-caused-by-buggy-bios-on-certain-boards-with-rtl8168d.patch
