This is a note to let you know that I've just added the patch titled mm/memory-failure: fix an incorrect use of tail pages to the 5.4-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: mm-memory-failure-fix-an-incorrect-use-of-tail-pages.patch and it can be found in the queue-5.4 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From liushixin2@xxxxxxxxxx Sat Mar 30 10:11:30 2024 From: Liu Shixin <liushixin2@xxxxxxxxxx> Date: Thu, 7 Mar 2024 20:50:53 +0800 Subject: mm/memory-failure: fix an incorrect use of tail pages To: Matthew Wilcox <willy@xxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Sasha Levin <sashal@xxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> Cc: <linux-kernel@xxxxxxxxxxxxxxx>, <linux-mm@xxxxxxxxx>, <stable@xxxxxxxxxxxxxxx>, Liu Shixin <liushixin2@xxxxxxxxxx> Message-ID: <20240307125053.2847205-1-liushixin2@xxxxxxxxxx> From: Liu Shixin <liushixin2@xxxxxxxxxx> When backport commit c79c5a0a00a9 to 5.4-stable, there is a mistake change. The head page instead of tail page should be passed to try_to_unmap(), otherwise unmap will failed as follows. Memory failure: 0x121c10: failed to unmap page (mapcount=1) Memory failure: 0x121c10: recovery action for unmapping failed page: Ignored Fixes: 85015a96bc24 ("mm/memory-failure: check the mapcount of the precise page") Signed-off-by: Liu Shixin <liushixin2@xxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- mm/memory-failure.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1030,7 +1030,7 @@ static bool hwpoison_user_mappings(struc if (kill) collect_procs(hpage, &tokill, flags & MF_ACTION_REQUIRED); - unmap_success = try_to_unmap(p, ttu); + unmap_success = try_to_unmap(hpage, ttu); if (!unmap_success) pr_err("Memory failure: %#lx: failed to unmap page (mapcount=%d)\n", pfn, page_mapcount(p)); Patches currently in stable-queue which might be from liushixin2@xxxxxxxxxx are queue-5.4/mm-memory-failure-fix-an-incorrect-use-of-tail-pages.patch