Hi
Am 10.03.24 um 22:54 schrieb Sasha Levin:
This is a note to let you know that I've just added the patch titled
drm/udl: Add ARGB8888 as a format
to the 6.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
drm-udl-add-argb8888-as-a-format.patch
and it can be found in the queue-6.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
Please remove. This patch has been reverted in commit 317f86dc1b8e
("Revert "drm/udl: Add ARGB8888 as a format"").
Best regards
Thomas
commit 4a5ff2cf2df9f96d32b6656278b8909c2ac659e0
Author: Douglas Anderson <dianders@xxxxxxxxxxxx>
Date: Tue Feb 27 14:19:29 2024 -0800
drm/udl: Add ARGB8888 as a format
[ Upstream commit 95bf25bb9ed5dedb7fb39f76489f7d6843ab0475 ]
Even though the UDL driver converts to RGB565 internally (see
pixel32_to_be16() in udl_transfer.c), it advertises XRGB8888 for
compatibility. Let's add ARGB8888 to that list.
This makes UDL devices work on ChromeOS again after commit
c91acda3a380 ("drm/gem: Check for valid formats"). Prior to that
commit things were "working" because we'd silently treat the ARGB8888
that ChromeOS wanted as XRGB8888.
Fixes: c91acda3a380 ("drm/gem: Check for valid formats")
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
Link: https://patchwork.freedesktop.org/patch/msgid/20240227141928.1.I24ac8d51544e4624b7e9d438d95880c4283e611b@changeid
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
index 40876bcdd79a4..c431c2e8f39a6 100644
--- a/drivers/gpu/drm/udl/udl_modeset.c
+++ b/drivers/gpu/drm/udl/udl_modeset.c
@@ -254,6 +254,7 @@ static int udl_handle_damage(struct drm_framebuffer *fb,
static const uint32_t udl_primary_plane_formats[] = {
DRM_FORMAT_RGB565,
DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_ARGB8888,
};
static const uint64_t udl_primary_plane_fmtmods[] = {
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
