This is a note to let you know that I've just added the patch titled
NFSD: Remove redundant assignment to variable host_err
to the 6.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
nfsd-remove-redundant-assignment-to-variable-host_err.patch
and it can be found in the queue-6.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 2e3aa79f392f5bfca11a1dbbdf422bc088a1a65a Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.i.king@xxxxxxxxx>
Date: Mon, 10 Oct 2022 21:24:23 +0100
Subject: NFSD: Remove redundant assignment to variable host_err
From: Colin Ian King <colin.i.king@xxxxxxxxx>
[ Upstream commit 69eed23baf877bbb1f14d7f4df54f89807c9ee2a ]
Variable host_err is assigned a value that is never read, it is being
re-assigned a value in every different execution path in the following
switch statement. The assignment is redundant and can be removed.
Cleans up clang-scan warning:
warning: Value stored to 'host_err' is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>
Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx>
Signed-off-by: Chuck Lever <chuck.lever@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
fs/nfsd/vfs.c | 1 -
1 file changed, 1 deletion(-)
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -1317,7 +1317,6 @@ nfsd_create_locked(struct svc_rqst *rqst
iap->ia_mode &= ~current_umask();
err = 0;
- host_err = 0;
switch (type) {
case S_IFREG:
host_err = vfs_create(&init_user_ns, dirp, dchild, iap->ia_mode, true);
Patches currently in stable-queue which might be from colin.i.king@xxxxxxxxx are
queue-6.1/nfsd-remove-redundant-assignment-to-variable-host_err.patch
