This is a note to let you know that I've just added the patch titled
ALSA: ump: Fix the discard error code from snd_ump_legacy_open()
to the 6.7-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
alsa-ump-fix-the-discard-error-code-from-snd_ump_legacy_open.patch
and it can be found in the queue-6.7 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 49cbb7b7d36ec3ba73ce1daf7ae1d71d435453b8 Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@xxxxxxx>
Date: Tue, 20 Feb 2024 16:08:43 +0100
Subject: ALSA: ump: Fix the discard error code from snd_ump_legacy_open()
From: Takashi Iwai <tiwai@xxxxxxx>
commit 49cbb7b7d36ec3ba73ce1daf7ae1d71d435453b8 upstream.
snd_ump_legacy_open() didn't return the error code properly even if it
couldn't open. Fix it.
Fixes: 0b5288f5fe63 ("ALSA: ump: Add legacy raw MIDI support")
Cc: <stable@xxxxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20240220150843.28630-1-tiwai@xxxxxxx
Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
sound/core/ump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/sound/core/ump.c
+++ b/sound/core/ump.c
@@ -985,7 +985,7 @@ static int snd_ump_legacy_open(struct sn
struct snd_ump_endpoint *ump = substream->rmidi->private_data;
int dir = substream->stream;
int group = ump->legacy_mapping[substream->number];
- int err;
+ int err = 0;
mutex_lock(&ump->open_mutex);
if (ump->legacy_substreams[dir][group]) {
@@ -1009,7 +1009,7 @@ static int snd_ump_legacy_open(struct sn
spin_unlock_irq(&ump->legacy_locks[dir]);
unlock:
mutex_unlock(&ump->open_mutex);
- return 0;
+ return err;
}
static int snd_ump_legacy_close(struct snd_rawmidi_substream *substream)
Patches currently in stable-queue which might be from tiwai@xxxxxxx are
queue-6.7/alsa-hda-realtek-add-special-fixup-for-lenovo-14irp8.patch
queue-6.7/alsa-hda-realtek-fix-mute-micmute-led-for-hp-mt440.patch
queue-6.7/alsa-firewire-lib-fix-to-check-cycle-continuity.patch
queue-6.7/alsa-drop-leftover-snd-rtctimer-stuff-from-makefile.patch
queue-6.7/alsa-hda-realtek-fix-top-speaker-connection-on-dell-inspiron-16-plus-7630.patch
queue-6.7/alsa-ump-fix-the-discard-error-code-from-snd_ump_legacy_open.patch
queue-6.7/alsa-hda-realtek-tas2781-enable-subwoofer-volume-control.patch
queue-6.7/alsa-hda-realtek-enable-mute-led-on-hp-840-g8-mb-8ab8.patch
