Patch "ASoC: cs35l56: Must clear HALO_STATE before issuing SYSTEM_RESET" has been added to the 6.7-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    ASoC: cs35l56: Must clear HALO_STATE before issuing SYSTEM_RESET

to the 6.7-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     asoc-cs35l56-must-clear-halo_state-before-issuing-sy.patch
and it can be found in the queue-6.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 5132dca9cf4b6afd0f56d1725e01b21d4042fecf
Author: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
Date:   Fri Feb 16 14:05:35 2024 +0000

    ASoC: cs35l56: Must clear HALO_STATE before issuing SYSTEM_RESET
    
    [ Upstream commit e33625c84b75e4f078d7f9bf58f01fe71ab99642 ]
    
    The driver must write 0 to HALO_STATE before sending the SYSTEM_RESET
    command to the firmware.
    
    HALO_STATE is in DSP memory, which is preserved across a soft reset.
    The SYSTEM_RESET command does not change the value of HALO_STATE.
    There is period of time while the CS35L56 is resetting, before the
    firmware has started to boot, where a read of HALO_STATE will return
    the value it had before the SYSTEM_RESET. If the driver does not
    clear HALO_STATE, this would return BOOT_DONE status even though the
    firmware has not booted.
    
    Signed-off-by: Richard Fitzgerald <rf@xxxxxxxxxxxxxxxxxxxxx>
    Fixes: 8a731fd37f8b ("ASoC: cs35l56: Move utility functions to shared file")
    Link: https://msgid.link/r/20240216140535.1434933-1-rf@xxxxxxxxxxxxxxxxxxxxx
    Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/sound/soc/codecs/cs35l56-shared.c b/sound/soc/codecs/cs35l56-shared.c
index 953ba066bab1e..fc99bc92aeace 100644
--- a/sound/soc/codecs/cs35l56-shared.c
+++ b/sound/soc/codecs/cs35l56-shared.c
@@ -286,6 +286,7 @@ void cs35l56_wait_min_reset_pulse(void)
 EXPORT_SYMBOL_NS_GPL(cs35l56_wait_min_reset_pulse, SND_SOC_CS35L56_SHARED);
 
 static const struct reg_sequence cs35l56_system_reset_seq[] = {
+	REG_SEQ0(CS35L56_DSP1_HALO_STATE, 0),
 	REG_SEQ0(CS35L56_DSP_VIRTUAL1_MBOX_1, CS35L56_MBOX_CMD_SYSTEM_RESET),
 };
 




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux