This is a note to let you know that I've just added the patch titled tracing: Fix a NULL vs IS_ERR() bug in event_subsystem_dir() to the 6.6-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: tracing-fix-a-null-vs-is_err-bug-in-event_subsystem_dir.patch and it can be found in the queue-6.6 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <stable@xxxxxxxxxxxxxxx> know about it. >From 5264a2f4bb3baf712e19f1f053caaa8d7d3afa2e Mon Sep 17 00:00:00 2001 From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Date: Fri, 20 Oct 2023 16:52:45 +0300 Subject: tracing: Fix a NULL vs IS_ERR() bug in event_subsystem_dir() From: Dan Carpenter <dan.carpenter@xxxxxxxxxx> commit 5264a2f4bb3baf712e19f1f053caaa8d7d3afa2e upstream. The eventfs_create_dir() function returns error pointers, it never returns NULL. Update the check to reflect that. Link: https://lore.kernel.org/linux-trace-kernel/ff641474-84e2-46a7-9d7a-62b251a1050c@moroto.mountain Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx> Fixes: 5790b1fb3d67 ("eventfs: Remove eventfs_file and just use eventfs_inode") Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Signed-off-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- kernel/trace/trace_events.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -2374,7 +2374,7 @@ event_subsystem_dir(struct trace_array * nr_entries = ARRAY_SIZE(system_entries); ei = eventfs_create_dir(name, parent, system_entries, nr_entries, dir); - if (!ei) { + if (IS_ERR(ei)) { pr_warn("Failed to create system directory %s\n", name); __put_system(system); goto out_free; Patches currently in stable-queue which might be from dan.carpenter@xxxxxxxxxx are queue-6.6/wifi-iwlwifi-uninitialized-variable-in-iwl_acpi_get_.patch queue-6.6/wifi-iwlwifi-fix-some-error-codes.patch queue-6.6/cifs-fix-underflow-in-parse_server_interfaces.patch queue-6.6/hid-bpf-remove-double-fdget.patch queue-6.6/tracing-fix-a-null-vs-is_err-bug-in-event_subsystem_dir.patch