This is a note to let you know that I've just added the patch titled
serial: max310x: set default value when reading clock ready bit
to the 6.6-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
serial-max310x-set-default-value-when-reading-clock-ready-bit.patch
and it can be found in the queue-6.6 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 0419373333c2f2024966d36261fd82a453281e80 Mon Sep 17 00:00:00 2001
From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
Date: Tue, 16 Jan 2024 16:29:58 -0500
Subject: serial: max310x: set default value when reading clock ready bit
From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
commit 0419373333c2f2024966d36261fd82a453281e80 upstream.
If regmap_read() returns a non-zero value, the 'val' variable can be left
uninitialized.
Clear it before calling regmap_read() to make sure we properly detect
the clock ready bit.
Fixes: 4cf9a888fd3c ("serial: max310x: Check the clock readiness")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20240116213001.3691629-2-hugo@xxxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/tty/serial/max310x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/tty/serial/max310x.c
+++ b/drivers/tty/serial/max310x.c
@@ -641,7 +641,7 @@ static u32 max310x_set_ref_clk(struct de
/* Wait for crystal */
if (xtal) {
- unsigned int val;
+ unsigned int val = 0;
msleep(10);
regmap_read(s->regmap, MAX310X_STS_IRQSTS_REG, &val);
if (!(val & MAX310X_STS_CLKREADY_BIT)) {
Patches currently in stable-queue which might be from hvilleneuve@xxxxxxxxxxxx are
queue-6.6/serial-max310x-fail-probe-if-clock-crystal-is-unstable.patch
queue-6.6/serial-max310x-prevent-infinite-while-loop-in-port-startup.patch
queue-6.6/serial-max310x-set-default-value-when-reading-clock-ready-bit.patch
queue-6.6/serial-max310x-improve-crystal-stable-clock-detection.patch
