This is a note to let you know that I've just added the patch titled
Revert "driver core: Annotate dev_err_probe() with __must_check"
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
revert-driver-core-annotate-dev_err_probe-with-__must_check.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From f601e8f37c2c1c52f2923fffc48204a7f7dc023d Mon Sep 17 00:00:00 2001
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 9 Sep 2020 09:37:40 +0200
Subject: Revert "driver core: Annotate dev_err_probe() with __must_check"
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
commit f601e8f37c2c1c52f2923fffc48204a7f7dc023d upstream.
This reverts commit e1f82a0dcf388d98bcc7ad195c03bd812405e6b2 as it's
already starting to cause build warnings in linux-next for things that
are "obviously correct".
It's up to driver authors do "do the right thing" here with this
function, and if they don't want to call it as the last line of a
function, that's up to them, otherwise code that looks like:
ret = dev_err_probe(..., ret, ...);
does look really "odd".
Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>
Reported-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Fixes: e1f82a0dcf38 ("driver core: Annotate dev_err_probe() with __must_check")
Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
include/linux/device.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -1582,7 +1582,7 @@ do { \
dev_driver_string(dev), dev_name(dev), ## arg)
extern __printf(3, 4)
-int __must_check dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
+int dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
/* Create alias, so I can be autoloaded. */
#define MODULE_ALIAS_CHARDEV(major,minor) \
Patches currently in stable-queue which might be from gregkh@xxxxxxxxxxxxxxxxxxx are
queue-4.19/nouveau-vmm-don-t-set-addr-on-the-fail-path-to-avoid-warning.patch
queue-4.19/serial-sc16is7xx-add-check-for-unsupported-spi-modes.patch
queue-4.19/mips-call-lose_fpu-0-before-initializing-fcr31-in-mips_set_personality_nan.patch
queue-4.19/drm-bridge-nxp-ptn3460-fix-i2c_master_send-error-checking.patch
queue-4.19/driver-core-annotate-dev_err_probe-with-__must_check.patch
queue-4.19/tick-sched-preserve-number-of-idle-sleeps-across-cpu-hotplug-events.patch
queue-4.19/netfilter-nf_tables-reject-queue-drop-verdict-parameters.patch
queue-4.19/serial-sc16is7xx-set-safe-default-spi-clock-frequenc.patch
queue-4.19/crypto-api-disallow-identical-driver-names.patch
queue-4.19/drm-don-t-unref-the-same-fb-many-times-by-mistake-due-to-deadlock-handling.patch
queue-4.19/revert-driver-core-annotate-dev_err_probe-with-__must_check.patch
queue-4.19/block-remove-special-casing-of-compound-pages.patch
queue-4.19/ext4-allow-for-the-last-group-to-be-marked-as-trimmed.patch
queue-4.19/btrfs-defrag-reject-unknown-flags-of-btrfs_ioctl_defrag_range_args.patch
queue-4.19/gpiolib-acpi-ignore-touchpad-wakeup-on-gpd-g1619-04.patch
queue-4.19/driver-core-add-device-probe-log-helper.patch
queue-4.19/drm-bridge-nxp-ptn3460-simplify-some-error-checking.patch
queue-4.19/hwrng-core-fix-page-fault-dead-lock-on-mmap-ed-hwrng.patch
queue-4.19/parisc-firmware-fix-f-extend-for-pdc-addresses.patch
queue-4.19/x86-cpu-amd-fix-disabling-xsaves-on-amd-family-0x17-due-to-erratum.patch
queue-4.19/pm-hibernate-enforce-ordering-during-image-compression-decompression.patch
queue-4.19/x86-entry-ia32-ensure-s32-is-sign-extended-to-s64.patch
queue-4.19/powerpc-use-always-instead-of-always-y-in-for-crtsavres.o.patch
queue-4.19/driver-code-print-symbolic-error-code.patch
queue-4.19/btrfs-don-t-warn-if-discard-range-is-not-aligned-to-sector.patch
queue-4.19/rpmsg-virtio-free-driver_override-when-rpmsg_remove.patch
queue-4.19/drivers-core-fix-kernel-doc-markup-for-dev_err_probe.patch
