Re: Patch "binder: print warnings when detecting oneway spamming." has been added to the 5.4-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 22, 2024 at 07:21:39PM -0500, Sasha Levin wrote:
> This is a note to let you know that I've just added the patch titled
> 
>     binder: print warnings when detecting oneway spamming.
> 
> to the 5.4-stable tree which can be found at:
>     http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> 
> The filename of the patch is:
>      binder-print-warnings-when-detecting-oneway-spamming.patch
> and it can be found in the queue-5.4 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.
> 
> 
> 
> commit d6d504e7bb58e0999f8199bb4e1e20c839b9bfed
> Author: Martijn Coenen <maco@xxxxxxxxxxx>
> Date:   Fri Aug 21 14:25:44 2020 +0200
> 
>     binder: print warnings when detecting oneway spamming.
>     
>     [ Upstream commit 261e7818f06ec51e488e007f787ccd7e77272918 ]
>     
>     The most common cause of the binder transaction buffer filling up is a
>     client rapidly firing oneway transactions into a process, before it has
>     a chance to handle them. Yet the root cause of this is often hard to
>     debug, because either the system or the app will stop, and by that time
>     binder debug information we dump in bugreports is no longer relevant.
>     
>     This change warns as soon as a process dips below 80% of its oneway
>     space (less than 100kB available in the configuration), when any one
>     process is responsible for either more than 50 transactions, or more
>     than 50% of the oneway space.
>     
>     Signed-off-by: Martijn Coenen <maco@xxxxxxxxxxx>
>     Acked-by: Todd Kjos <tkjos@xxxxxxxxxx>
>     Link: https://lore.kernel.org/r/20200821122544.1277051-1-maco@xxxxxxxxxxx
>     Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>     Stable-dep-of: c6d05e0762ab ("binder: fix unused alloc->free_async_space")
>     Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> 

This should not be added to the 5.4 stable tree. It's part of a feature
that doesn't exist in this kernel version. The commit quoted as a
dependency in the tags has been instead fixed to avoid the merge issue.

Thanks,
--
Carlos Llamas




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux