This is a note to let you know that I've just added the patch titled
tty: don't check for signal_pending() in send_break()
to the 5.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
tty-don-t-check-for-signal_pending-in-send_break.patch
and it can be found in the queue-5.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
commit 6d2405e17204f870e4be7de85fc5e3b24d5ce07d
Author: Jiri Slaby (SUSE) <jirislaby@xxxxxxxxxx>
Date: Tue Sep 19 10:51:55 2023 +0200
tty: don't check for signal_pending() in send_break()
[ Upstream commit fd99392b643b824813df2edbaebe26a2136d31e6 ]
msleep_interruptible() will check on its own. So no need to do the check
in send_break() before calling the above.
Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@xxxxxxxxxx>
Link: https://lore.kernel.org/r/20230919085156.1578-15-jirislaby@xxxxxxxxxx
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Stable-dep-of: 66aad7d8d3ec ("usb: cdc-acm: return correct error code on unsupported break")
Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 145c26401218..a45e6e1423d8 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -2479,8 +2479,7 @@ static int send_break(struct tty_struct *tty, unsigned int duration)
retval = tty->ops->break_ctl(tty, -1);
if (retval)
goto out;
- if (!signal_pending(current))
- msleep_interruptible(duration);
+ msleep_interruptible(duration);
retval = tty->ops->break_ctl(tty, 0);
out:
tty_write_unlock(tty);
