This is a note to let you know that I've just added the patch titled
crypto: scompress - initialize per-CPU variables on each CPU
to the 4.19-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
crypto-scompress-initialize-per-cpu-variables-on-each-cpu.patch
and it can be found in the queue-4.19 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 8c3fffe3993b06dd1955a79bd2f0f3b143d259b3 Mon Sep 17 00:00:00 2001
From: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Date: Fri, 12 Apr 2019 17:14:15 +0200
Subject: crypto: scompress - initialize per-CPU variables on each CPU
From: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
commit 8c3fffe3993b06dd1955a79bd2f0f3b143d259b3 upstream.
In commit 71052dcf4be70 ("crypto: scompress - Use per-CPU struct instead
multiple variables") I accidentally initialized multiple times the memory on a
random CPU. I should have initialize the memory on every CPU like it has
been done earlier. I didn't notice this because the scheduler didn't
move the task to another CPU.
Guenter managed to do that and the code crashed as expected.
Allocate / free per-CPU memory on each CPU.
Fixes: 71052dcf4be70 ("crypto: scompress - Use per-CPU struct instead multiple variables")
Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
crypto/scompress.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/crypto/scompress.c
+++ b/crypto/scompress.c
@@ -79,7 +79,7 @@ static void crypto_scomp_free_scratches(
int i;
for_each_possible_cpu(i) {
- scratch = raw_cpu_ptr(&scomp_scratch);
+ scratch = per_cpu_ptr(&scomp_scratch, i);
vfree(scratch->src);
vfree(scratch->dst);
@@ -96,7 +96,7 @@ static int crypto_scomp_alloc_scratches(
for_each_possible_cpu(i) {
void *mem;
- scratch = raw_cpu_ptr(&scomp_scratch);
+ scratch = per_cpu_ptr(&scomp_scratch, i);
mem = vmalloc_node(SCOMP_SCRATCH_SIZE, cpu_to_node(i));
if (!mem)
Patches currently in stable-queue which might be from bigeasy@xxxxxxxxxxxxx are
queue-4.19/crypto-scompress-initialize-per-cpu-variables-on-each-cpu.patch
queue-4.19/fbdev-flush-deferred-work-in-fb_deferred_io_fsync.patch
queue-4.19/crypto-scompress-return-proper-error-code-for-alloca.patch
queue-4.19/crypto-scompress-use-per-cpu-struct-instead-multiple.patch
