Patch "net: netdev_queue: netdev_txq_completed_mb(): fix wake condition" has been added to the 6.7-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    net: netdev_queue: netdev_txq_completed_mb(): fix wake condition

to the 6.7-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     net-netdev_queue-netdev_txq_completed_mb-fix-wake-co.patch
and it can be found in the queue-6.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit dab40229fa3ba147e01240af80b1ceab89f12eef
Author: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
Date:   Fri Jan 12 17:13:14 2024 +0100

    net: netdev_queue: netdev_txq_completed_mb(): fix wake condition
    
    [ Upstream commit 894d7508316e7ad722df597d68b4b1797a9eee11 ]
    
    netif_txq_try_stop() uses "get_desc >= start_thrs" as the check for
    the call to netif_tx_start_queue().
    
    Use ">=" i netdev_txq_completed_mb(), too.
    
    Fixes: c91c46de6bbc ("net: provide macros for commonly copied lockless queue stop/wake code")
    Signed-off-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
    Acked-by: Jakub Kicinski <kuba@xxxxxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/include/net/netdev_queues.h b/include/net/netdev_queues.h
index d68b0a483431..8b8ed4e13d74 100644
--- a/include/net/netdev_queues.h
+++ b/include/net/netdev_queues.h
@@ -128,7 +128,7 @@ netdev_txq_completed_mb(struct netdev_queue *dev_queue,
 		netdev_txq_completed_mb(txq, pkts, bytes);		\
 									\
 		_res = -1;						\
-		if (pkts && likely(get_desc > start_thrs)) {		\
+		if (pkts && likely(get_desc >= start_thrs)) {		\
 			_res = 1;					\
 			if (unlikely(netif_tx_queue_stopped(txq)) &&	\
 			    !(down_cond)) {				\




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux