Patch "perf test record user-regs: Fix mask for vg register" has been added to the 6.7-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    perf test record user-regs: Fix mask for vg register

to the 6.7-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     perf-test-record-user-regs-fix-mask-for-vg-register.patch
and it can be found in the queue-6.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 1bbfb8671dbc92b055047037591d443d2e6d9046
Author: Veronika Molnarova <vmolnaro@xxxxxxxxxx>
Date:   Fri Dec 1 20:46:17 2023 +0100

    perf test record user-regs: Fix mask for vg register
    
    [ Upstream commit 28b01743ca752cea5ab182297d8b912b22f2a2d1 ]
    
    The 'vg' register for arm64 shows up in --user_regs as available when
    masking the variable AT_HWCAP with 1 << 22 returns '1' as done in
    perf_regs.c.
    
    However, in subtests for support of SVE, the check for the 'vg' register
    is done by masking the variable AT_HWCAP with the value 0x200000 which
    is equals to 1 << 21 instead of 1 << 22.
    
    This results in inconsistencies on certain systems where the test
    expects that the 'vg' register is not operational when it is, and
    vice-versa.
    
    During the testing on a machine that the test expected not to have the
    'vg' register available, 'perf record' with the option --user-regs
    showed records for the 'vg' register together with all of the others,
    which means that the mask for the subtest of perf_event_attr is off by
    one.
    
    Change the value of the mask from 0x200000 to 0x400000 to correct it.
    
    Fixes: 9440ebdc333dd12e ("perf test arm64: Add attr tests for new VG register")
    Reviewed-by: Leo Yan <leo.yan@xxxxxxxxxx>
    Signed-off-by: Veronika Molnarova <vmolnaro@xxxxxxxxxx>
    Cc: James Clark <james.clark@xxxxxxx>
    Cc: Michael Petlan <mpetlan@xxxxxxxxxx>
    Link: https://lore.kernel.org/r/20231201194617.13012-1-vmolnaro@xxxxxxxxxx
    Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/tools/perf/tests/attr/test-record-user-regs-no-sve-aarch64 b/tools/perf/tests/attr/test-record-user-regs-no-sve-aarch64
index fbb065842880..bed765450ca9 100644
--- a/tools/perf/tests/attr/test-record-user-regs-no-sve-aarch64
+++ b/tools/perf/tests/attr/test-record-user-regs-no-sve-aarch64
@@ -6,4 +6,4 @@ args    = --no-bpf-event --user-regs=vg kill >/dev/null 2>&1
 ret     = 129
 test_ret = true
 arch    = aarch64
-auxv    = auxv["AT_HWCAP"] & 0x200000 == 0
+auxv    = auxv["AT_HWCAP"] & 0x400000 == 0
diff --git a/tools/perf/tests/attr/test-record-user-regs-sve-aarch64 b/tools/perf/tests/attr/test-record-user-regs-sve-aarch64
index c598c803221d..a65113cd7311 100644
--- a/tools/perf/tests/attr/test-record-user-regs-sve-aarch64
+++ b/tools/perf/tests/attr/test-record-user-regs-sve-aarch64
@@ -6,7 +6,7 @@ args    = --no-bpf-event --user-regs=vg kill >/dev/null 2>&1
 ret     = 1
 test_ret = true
 arch    = aarch64
-auxv    = auxv["AT_HWCAP"] & 0x200000 == 0x200000
+auxv    = auxv["AT_HWCAP"] & 0x400000 == 0x400000
 kernel_since = 6.1
 
 [event:base-record]




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux