Patch "kselftest/alsa - conf: Stringify the printed errno in sysfs_get()" has been added to the 6.7-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    kselftest/alsa - conf: Stringify the printed errno in sysfs_get()

to the 6.7-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     kselftest-alsa-conf-stringify-the-printed-errno-in-s.patch
and it can be found in the queue-6.7 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit da955920302afca887ecdddf28de82d80315f2ca
Author: Mirsad Todorovac <mirsad.todorovac@xxxxxxxxxxxx>
Date:   Sun Jan 7 18:37:08 2024 +0100

    kselftest/alsa - conf: Stringify the printed errno in sysfs_get()
    
    [ Upstream commit fd38dd6abda589a8771e7872e4dea28c99c6a6ef ]
    
    GCC 13.2.0 reported the warning of the print format specifier:
    
    conf.c: In function ‘sysfs_get’:
    conf.c:181:72: warning: format ‘%s’ expects argument of type ‘char *’, \
                            but argument 3 has type ‘int’ [-Wformat=]
      181 |                 ksft_exit_fail_msg("sysfs: unable to read value '%s': %s\n",
          |                                                                       ~^
          |                                                                        |
          |                                                                        char *
          |                                                                       %d
    
    The fix passes strerror(errno) as it was intended, like in the sibling error
    exit message.
    
    Fixes: aba51cd0949ae ("selftests: alsa - add PCM test")
    Cc: Mark Brown <broonie@xxxxxxxxxx>
    Cc: Jaroslav Kysela <perex@xxxxxxxx>
    Cc: Takashi Iwai <tiwai@xxxxxxxx>
    Cc: Shuah Khan <shuah@xxxxxxxxxx>
    Cc: linux-sound@xxxxxxxxxxxxxxx
    Cc: linux-kselftest@xxxxxxxxxxxxxxx
    Cc: linux-kernel@xxxxxxxxxxxxxxx
    Signed-off-by: Mirsad Todorovac <mirsad.todorovac@xxxxxxxxxxxx>
    Acked-by: Mark Brown <broonie@xxxxxxxxxx>
    Link: https://lore.kernel.org/r/20240107173704.937824-5-mirsad.todorovac@xxxxxxxxxxxx
    Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/tools/testing/selftests/alsa/conf.c b/tools/testing/selftests/alsa/conf.c
index 00925eb8d9f4..89e3656a042d 100644
--- a/tools/testing/selftests/alsa/conf.c
+++ b/tools/testing/selftests/alsa/conf.c
@@ -179,7 +179,7 @@ static char *sysfs_get(const char *sysfs_root, const char *id)
 	close(fd);
 	if (len < 0)
 		ksft_exit_fail_msg("sysfs: unable to read value '%s': %s\n",
-				   path, errno);
+				   path, strerror(errno));
 	while (len > 0 && path[len-1] == '\n')
 		len--;
 	path[len] = '\0';




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux