Patch "pinctrl: s32cc: Avoid possible string truncation" has been added to the 6.6-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    pinctrl: s32cc: Avoid possible string truncation

to the 6.6-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     pinctrl-s32cc-avoid-possible-string-truncation.patch
and it can be found in the queue-6.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 280db9f57a6565a0259612de1cf8712cb1108ca7
Author: Chester Lin <chester62515@xxxxxxxxx>
Date:   Tue Nov 7 22:10:44 2023 +0800

    pinctrl: s32cc: Avoid possible string truncation
    
    [ Upstream commit 08e8734d877a9a0fb8af1254a4ce58734fbef296 ]
    
    With "W=1" and "-Wformat-truncation" build options, the kernel test robot
    found a possible string truncation warning in pinctrl-s32cc.c, which uses
    an 8-byte char array to hold a memory region name "map%u". Since the
    maximum number of digits that a u32 value can present is 10, and the "map"
    string occupies 3 bytes with a termination '\0', which means the rest 4
    bytes cannot fully present the integer "X" that exceeds 4 digits.
    
    Here we check if the number >= 10000, which is the lowest value that
    contains more than 4 digits.
    
    Reported-by: kernel test robot <lkp@xxxxxxxxx>
    Closes: https://lore.kernel.org/oe-kbuild-all/202311030159.iyUGjNGF-lkp@xxxxxxxxx/
    Signed-off-by: Chester Lin <clin@xxxxxxxx>
    Link: https://lore.kernel.org/r/20231107141044.24058-1-clin@xxxxxxxx
    Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/pinctrl/nxp/pinctrl-s32cc.c b/drivers/pinctrl/nxp/pinctrl-s32cc.c
index 7daff9f186cd..f0cad2c501f7 100644
--- a/drivers/pinctrl/nxp/pinctrl-s32cc.c
+++ b/drivers/pinctrl/nxp/pinctrl-s32cc.c
@@ -843,8 +843,8 @@ static int s32_pinctrl_probe_dt(struct platform_device *pdev,
 	if (!np)
 		return -ENODEV;
 
-	if (mem_regions == 0) {
-		dev_err(&pdev->dev, "mem_regions is 0\n");
+	if (mem_regions == 0 || mem_regions >= 10000) {
+		dev_err(&pdev->dev, "mem_regions is invalid: %u\n", mem_regions);
 		return -EINVAL;
 	}
 




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux