This is a note to let you know that I've just added the patch titled
ath10k: Wait until copy complete is actually done before completing
to the 5.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ath10k-wait-until-copy-complete-is-actually-done-before-completing.patch
and it can be found in the queue-5.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From stable+bounces-10185-greg=kroah.com@xxxxxxxxxxxxxxx Mon Jan 8 16:37:49 2024
From: Amit Pundir <amit.pundir@xxxxxxxxxx>
Date: Mon, 8 Jan 2024 21:07:34 +0530
Subject: ath10k: Wait until copy complete is actually done before completing
To: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>, Sasha Levin <sashal@xxxxxxxxxx>, Douglas Anderson <dianders@xxxxxxxxxxxx>, Rakesh Pillai <pillair@xxxxxxxxxxxxxx>
Cc: Yongqin Liu <yongqin.liu@xxxxxxxxxx>, Stable <stable@xxxxxxxxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxxxxxx>
Message-ID: <20240108153737.3538218-2-amit.pundir@xxxxxxxxxx>
From: Douglas Anderson <dianders@xxxxxxxxxxxx>
[ Upstream commit 8f9ed93d09a97444733d492a3bbf66bcb786a777 ]
On wcn3990 we have "per_ce_irq = true". That makes the
ath10k_ce_interrupt_summary() function always return 0xfff. The
ath10k_ce_per_engine_service_any() function will see this and think
that _all_ copy engines have an interrupt. Without checking, the
ath10k_ce_per_engine_service() assumes that if it's called that the
"copy complete" (cc) interrupt fired. This combination seems bad.
Let's add a check to make sure that the "copy complete" interrupt
actually fired in ath10k_ce_per_engine_service().
This might fix a hard-to-reproduce failure where it appears that the
copy complete handlers run before the copy is really complete.
Specifically a symptom was that we were seeing this on a Qualcomm
sc7180 board:
arm-smmu 15000000.iommu: Unhandled context fault:
fsr=0x402, iova=0x7fdd45780, fsynr=0x30003, cbfrsynra=0xc1, cb=10
Even on platforms that don't have wcn3990 this still seems like it
would be a sane thing to do. Specifically the current IRQ handler
comments indicate that there might be other misc interrupt sources
firing that need to be cleared. If one of those sources was the one
that caused the IRQ handler to be called it would also be important to
double-check that the interrupt we cared about actually fired.
Tested-on: WCN3990 SNOC WLAN.HL.3.2.2-00490-QCAHLSWMTPL-1
Signed-off-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
Signed-off-by: Kalle Valo <kvalo@xxxxxxxxxxxxxx>
Link: https://lore.kernel.org/r/20200609082015.1.Ife398994e5a0a6830e4d4a16306ef36e0144e7ba@changeid
Stable-dep-of: 170c75d43a77 ("ath10k: Don't touch the CE interrupt registers after power up")
Signed-off-by: Amit Pundir <amit.pundir@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/net/wireless/ath/ath10k/ce.c | 30 +++++++++++++++++++++---------
1 file changed, 21 insertions(+), 9 deletions(-)
--- a/drivers/net/wireless/ath/ath10k/ce.c
+++ b/drivers/net/wireless/ath/ath10k/ce.c
@@ -481,6 +481,15 @@ static inline void ath10k_ce_engine_int_
ath10k_ce_write32(ar, ce_ctrl_addr + wm_regs->addr, mask);
}
+static inline bool ath10k_ce_engine_int_status_check(struct ath10k *ar,
+ u32 ce_ctrl_addr,
+ unsigned int mask)
+{
+ struct ath10k_hw_ce_host_wm_regs *wm_regs = ar->hw_ce_regs->wm_regs;
+
+ return ath10k_ce_read32(ar, ce_ctrl_addr + wm_regs->addr) & mask;
+}
+
/*
* Guts of ath10k_ce_send.
* The caller takes responsibility for any needed locking.
@@ -1301,19 +1310,22 @@ void ath10k_ce_per_engine_service(struct
spin_lock_bh(&ce->ce_lock);
- /* Clear the copy-complete interrupts that will be handled here. */
- ath10k_ce_engine_int_status_clear(ar, ctrl_addr,
- wm_regs->cc_mask);
+ if (ath10k_ce_engine_int_status_check(ar, ctrl_addr,
+ wm_regs->cc_mask)) {
+ /* Clear before handling */
+ ath10k_ce_engine_int_status_clear(ar, ctrl_addr,
+ wm_regs->cc_mask);
- spin_unlock_bh(&ce->ce_lock);
+ spin_unlock_bh(&ce->ce_lock);
- if (ce_state->recv_cb)
- ce_state->recv_cb(ce_state);
+ if (ce_state->recv_cb)
+ ce_state->recv_cb(ce_state);
- if (ce_state->send_cb)
- ce_state->send_cb(ce_state);
+ if (ce_state->send_cb)
+ ce_state->send_cb(ce_state);
- spin_lock_bh(&ce->ce_lock);
+ spin_lock_bh(&ce->ce_lock);
+ }
/*
* Misc CE interrupts are not being handled, but still need
Patches currently in stable-queue which might be from kroah.com@xxxxxxxxxxxxxxx are
queue-5.4/ath10k-get-rid-of-per_ce_irq-hw-param.patch
queue-5.4/ath10k-wait-until-copy-complete-is-actually-done-before-completing.patch
queue-5.4/ath10k-keep-track-of-which-interrupts-fired-don-t-poll-them.patch
queue-5.4/ath10k-add-interrupt-summary-based-ce-processing.patch
