This is a note to let you know that I've just added the patch titled
iio: adc: ti_am335x_adc: Fix return value check of tiadc_request_dma()
to the 5.10-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
iio-adc-ti_am335x_adc-fix-return-value-check-of-tiadc_request_dma.patch
and it can be found in the queue-5.10 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.
>From 60576e84c187043cef11f11d015249e71151d35a Mon Sep 17 00:00:00 2001
From: Wadim Egorov <w.egorov@xxxxxxxxx>
Date: Mon, 25 Sep 2023 15:44:27 +0200
Subject: iio: adc: ti_am335x_adc: Fix return value check of tiadc_request_dma()
From: Wadim Egorov <w.egorov@xxxxxxxxx>
commit 60576e84c187043cef11f11d015249e71151d35a upstream.
Fix wrong handling of a DMA request where the probing only failed
if -EPROPE_DEFER was returned. Instead, let us fail if a non -ENODEV
value is returned. This makes DMAs explicitly optional. Even if the
DMA request is unsuccessfully, the ADC can still work properly.
We do also handle the defer probe case by making use of dev_err_probe().
Fixes: f438b9da75eb ("drivers: iio: ti_am335x_adc: add dma support")
Signed-off-by: Wadim Egorov <w.egorov@xxxxxxxxx>
Reviewed-by: Bhavya Kapoor <b-kapoor@xxxxxx>
Link: https://lore.kernel.org/r/20230925134427.214556-1-w.egorov@xxxxxxxxx
Cc: <Stable@xxxxxxxxxxxxxxx>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/iio/adc/ti_am335x_adc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/drivers/iio/adc/ti_am335x_adc.c
+++ b/drivers/iio/adc/ti_am335x_adc.c
@@ -640,8 +640,10 @@ static int tiadc_probe(struct platform_d
platform_set_drvdata(pdev, indio_dev);
err = tiadc_request_dma(pdev, adc_dev);
- if (err && err == -EPROBE_DEFER)
+ if (err && err != -ENODEV) {
+ dev_err_probe(&pdev->dev, err, "DMA request failed\n");
goto err_dma;
+ }
return 0;
Patches currently in stable-queue which might be from w.egorov@xxxxxxxxx are
queue-5.10/iio-adc-ti_am335x_adc-fix-return-value-check-of-tiadc_request_dma.patch
