Patch "ice: Fix PF with enabled XDP going no-carrier after reset" has been added to the 6.6-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    ice: Fix PF with enabled XDP going no-carrier after reset

to the 6.6-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     ice-fix-pf-with-enabled-xdp-going-no-carrier-after-r.patch
and it can be found in the queue-6.6 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.



commit 2509d14c00daac3d748dac92e74b92ccfdb1f205
Author: Larysa Zaremba <larysa.zaremba@xxxxxxxxx>
Date:   Tue Dec 12 10:29:01 2023 +0100

    ice: Fix PF with enabled XDP going no-carrier after reset
    
    [ Upstream commit f5728a418945ba53e2fdf38a6e5c5a2670965e85 ]
    
    Commit 6624e780a577fc596788 ("ice: split ice_vsi_setup into smaller
    functions") has refactored a bunch of code involved in PFR. In this
    process, TC queue number adjustment for XDP was lost. Bring it back.
    
    Lack of such adjustment causes interface to go into no-carrier after a
    reset, if XDP program is attached, with the following message:
    
    ice 0000:b1:00.0: Failed to set LAN Tx queue context, error: -22
    ice 0000:b1:00.0 ens801f0np0: Failed to open VSI 0x0006 on switch 0x0001
    ice 0000:b1:00.0: enable VSI failed, err -22, VSI index 0, type ICE_VSI_PF
    ice 0000:b1:00.0: PF VSI rebuild failed: -22
    ice 0000:b1:00.0: Rebuild failed, unload and reload driver
    
    Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions")
    Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>
    Signed-off-by: Larysa Zaremba <larysa.zaremba@xxxxxxxxx>
    Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
    Tested-by: Chandan Kumar Rout <chandanx.rout@xxxxxxxxx> (A Contingent Worker at Intel)
    Signed-off-by: Tony Nguyen <anthony.l.nguyen@xxxxxxxxx>
    Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>

diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c
index 8dbf7a381e49b..a66c3b6ccec1e 100644
--- a/drivers/net/ethernet/intel/ice/ice_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_lib.c
@@ -2384,6 +2384,9 @@ static int ice_vsi_cfg_tc_lan(struct ice_pf *pf, struct ice_vsi *vsi)
 		} else {
 			max_txqs[i] = vsi->alloc_txq;
 		}
+
+		if (vsi->type == ICE_VSI_PF)
+			max_txqs[i] += vsi->num_xdp_txq;
 	}
 
 	dev_dbg(dev, "vsi->tc_cfg.ena_tc = %d\n", vsi->tc_cfg.ena_tc);




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux